Skip to content

[vm] Move or fix language_2/deopt_inlined_function_lazy_test, deopt_smi_test #37468

Open
@rakudrama

Description

@rakudrama

language_2/deopt_inlined_function_lazy_test.dart appears to be VM-jit specific and the test does not compile on dart2js/ddc due to an unsupported integer literal.

This places a burden on the ddc and dart2js teams when we review failing tests.

Please do one of the following:

  • The is VM-specific so does not really belong in language_2 - perhaps it should be moved to VM-specific directory?
  • The large integer literal seems important to the test. Perhaps it could be changed to another large integer literal that is accepted by the web platform?
  • It appears that with 64-bit ints, the test might now be useless, so perhaps the test should be deleted?

Ditto language_2/deopt_smi_test.dart.

The other 'deopt' tests should also probably be moved out of language_2, but so long as they pass on ddc/dart2js they don't place a burden on us, so we don't really care.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.customer-dart2jscustomer-dev-compiler

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions