Remove underused exports from analyzer.dart

Work towards #50986

The few rules that need this or that can import it themselves; this
helps us understand what parts of private API are needed more and less;
plugin authors should not be importing private API; this gives us
signal about which private API should maybe be offered as public API.

Change-Id: Id5ac0e48132d7e10e67e1f122ab63e5c2287f226
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429060
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/linter/lib/src/analyzer.dart

@@ -2,12 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-export 'package:analyzer/dart/element/type_system.dart';
-export 'package:analyzer/source/line_info.dart';
-export 'package:analyzer/src/dart/element/inheritance_manager3.dart'
-    show InheritanceManager3, Name;
 export 'package:analyzer/src/dart/error/lint_codes.dart';
-export 'package:analyzer/src/lint/analysis_rule_timers.dart';
 export 'package:analyzer/src/lint/linter.dart'
     show
         dart2_12,

pkg/linter/lib/src/rules/avoid_type_to_string.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';

pkg/linter/lib/src/rules/collection_methods_unrelated_type.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/dart/element/type_provider.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';

pkg/linter/lib/src/rules/invalid_runtime_check_with_js_interop_types.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 // ignore: implementation_imports
 import 'package:analyzer/src/dart/element/type.dart';

pkg/linter/lib/src/rules/leading_newlines_in_multiline_strings.dart

@@ -5,6 +5,7 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
+import 'package:analyzer/source/line_info.dart';
 
 import '../analyzer.dart';
 
@@ -36,7 +37,7 @@ class LeadingNewlinesInMultilineStrings extends LintRule {
 class _Visitor extends SimpleAstVisitor<void> {
   final LintRule rule;
 
-  LineInfo? lineInfo;
+  late LineInfo lineInfo;
 
   _Visitor(this.rule);
 
@@ -59,13 +60,9 @@ class _Visitor extends SimpleAstVisitor<void> {
   }
 
   void _visitSingleStringLiteral(SingleStringLiteral node, String lexeme) {
-    var nodeLineInfo = lineInfo;
-    if (nodeLineInfo == null) {
-      return;
-    }
     if (node.isMultiline &&
-        nodeLineInfo.getLocation(node.offset).lineNumber !=
-            nodeLineInfo.getLocation(node.end).lineNumber) {
+        lineInfo.getLocation(node.offset).lineNumber !=
+            lineInfo.getLocation(node.end).lineNumber) {
       bool startWithNewLine(int index) =>
           lexeme.startsWith('\n', index) || lexeme.startsWith('\r', index);
       if (!startWithNewLine(node.isRaw ? 4 : 3)) {

pkg/linter/lib/src/rules/lines_longer_than_80_chars.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
+import 'package:analyzer/source/line_info.dart';
 
 import '../analyzer.dart';
 

pkg/linter/lib/src/rules/require_trailing_commas.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
+import 'package:analyzer/source/line_info.dart';
 import 'package:pub_semver/pub_semver.dart';
 
 import '../analyzer.dart';

pkg/linter/lib/src/rules/unnecessary_await_in_return.dart

@@ -5,6 +5,7 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';

pkg/linter/lib/src/rules/unnecessary_lambdas.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';

pkg/linter/lib/src/rules/unnecessary_parenthesis.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';

pkg/linter/lib/src/rules/unrelated_type_equality_checks.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';

pkg/linter/lib/src/rules/void_checks.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/dart/element/type_system.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';

pkg/linter/test/formatter_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/diagnostic/diagnostic.dart';
-import 'package:linter/src/analyzer.dart';
+import 'package:analyzer/source/line_info.dart';
 import 'package:linter/src/test_utilities/analysis_error_info.dart';
 import 'package:test/test.dart';
 import 'package:test_descriptor/test_descriptor.dart' as d;

pkg/linter/tool/benchmark.dart

@@ -6,6 +6,7 @@ import 'dart:async';
 import 'dart:io';
 import 'dart:math' as math;
 
+import 'package:analyzer/src/lint/analysis_rule_timers.dart';
 import 'package:analyzer/src/lint/config.dart';
 import 'package:analyzer/src/lint/io.dart';
 import 'package:analyzer/src/lint/registry.dart';