[dart2js] Move tests from tests/web that are failing on DDC configurations into dart2js specific folder.

Also update dart2jsOptions on some tests that are failing on production/O0 configurations.

Change-Id: Ie0a8fa56dc391c98186f1573a76cff7ef6afde8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433563
Reviewed-by: Mayank Patke <[email protected]>

Author: natebiggs

pkg/compiler/lib/src/kernel/dart2js_target.dart

@@ -42,8 +42,9 @@ const Iterable<String> _allowedDartSchemePaths = [
 List<Pattern> _allowedNativeTestPatterns = [
   RegExp(r'(?<!generated_)tests/web/native'),
   RegExp(r'(?<!generated_)tests/web/internal'),
+  RegExp(r'(?<!generated_)tests/web/dart2js'),
   'generated_tests/web/native/native_test',
-  'generated_tests/web/internal/deferred_url_test',
+  'generated_tests/web/dart2js/deferred_url_test',
   'pkg/front_end/testcases/dart2js/native',
 ];
 

pkg/compiler/lib/src/options.dart

@@ -1155,6 +1155,8 @@ class CompilerOptions implements DiagnosticOptions {
     environment['dart.web.assertions_enabled'] = '$enableUserAssertions';
     environment['dart.tool.dart2js'] = '${true}';
     environment['dart.tool.dart2js.minify'] = '$enableMinification';
+    environment['dart.tool.dart2js.disable_rti_optimization'] =
+        '$disableRtiOptimization';
     // Eventually pragmas and commandline flags should be aligned so that users
     // setting these flag is equivalent to setting the relevant pragmas
     // globally.

pkg/expect/lib/variations.dart

@@ -130,6 +130,15 @@ bool get checkedParameters =>
 bool get checkedImplicitDowncasts =>
     !const bool.fromEnvironment('dart.tool.dart2js.types:trust');
 
+/// Whether RTI optimizations are disabled at compile time.
+///
+/// This can cause some type errors to present differently than they otherwise
+/// would. For example, when these optimizations are disabled ArgumentErrors may
+/// present as TypeErrors instead.
+bool get rtiOptimizationsDisabled =>
+    const bool.fromEnvironment('dart.tool.dart2js.disable_rti_optimization',
+        defaultValue: true);
+
 /// Whether explicit casts are type checked at runtime.
 ///
 /// An expression like `e as String` should perform a runtime check that the

tests/web/bounds_check4a_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// dart2jsOptions=--strong
+// dart2jsOptions=-O1
 
 import 'package:expect/expect.dart';
 

tests/web/bounds_check4b_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// dart2jsOptions=--strong
+// dart2jsOptions=-O1
 
 import 'package:expect/expect.dart';
 

tests/web/checked_setter_test.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// dart2jsOptions=-O1
+
 // Formatting can break multitests, so don't format them.
 // dart format off
 

tests/web/conditional_rewrite_test.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// dart2jsOptions=-O1
+
 import "package:expect/expect.dart";
 
 // Test that dart2js does not rewrite conditional into logical operators

tests/web/consistent_add_error_test.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// dart2jsOptions=-O1
+
 import "package:expect/expect.dart";
 
 // Test that optimized '+' and slow path '+' produce the same error.

tests/web/consistent_codeUnitAt_error_test.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// dart2jsOptions=-O1
+
 import "package:expect/expect.dart";
 
 // Test that optimized codeUnitAt and slow path codeUnitAt produce the same

tests/web/consistent_type_error_test.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// dart2jsOptions=-O1
+
 // Test that type checks give consistent errors for the same types. In minified
 // mode this checks that the minified class names are consistently tagged.