Migrate more tests over to the new style. (#1411)

In the process, I discovered a bug where the formatter would allow any
list-like construct (collection literal, etc.) to support block
formatting, which is definitely not intended. Only argument lists should
allow that.

Fixed that bug.

Author: munificent

lib/src/front_end/ast_node_visitor.dart

@@ -141,13 +141,13 @@ class AstNodeVisitor extends ThrowingAstVisitor<Piece> with PieceFactory {
   Piece visitAssertInitializer(AssertInitializer node) {
     return buildPiece((b) {
       b.token(node.assertKeyword);
-      b.add(createList(
-        leftBracket: node.leftParenthesis,
+      b.add(createArgumentList(
+        node.leftParenthesis,
         [
           node.condition,
           if (node.message case var message?) message,
         ],
-        rightBracket: node.rightParenthesis,
+        node.rightParenthesis,
       ));
     });
   }

lib/src/front_end/delimited_list_builder.dart

@@ -62,7 +62,7 @@ class DelimitedListBuilder {
       });
     }
 
-    _setBlockElementFormatting();
+    if (_style.allowBlockElement) _setBlockElementFormatting();
 
     var piece =
         ListPiece(_leftBracket, _elements, _blanksAfter, _rightBracket, _style);

test/declaration/constructor_assert.unit

@@ -79,4 +79,20 @@ class Foo {
          anotherLongCondition,
          'a message',
        );
+}
+>>> Allow block-formatting the assert arguments.
+class Foo {
+  Foo()
+    : assert(
+        () {
+          slowComputation();
+        }(),
+      );
+}
+<<<
+class Foo {
+  Foo()
+    : assert(() {
+        slowComputation();
+      }());
 }

test/expression/collection_if.stmt

@@ -133,6 +133,23 @@ var list = [
   if (condition)
     if (another) longThingHereThatsLong,
 ];
+>>> Split outer if when subelement is for.
+var list = [
+  if (a) for (var b in c) thing
+];
+<<<
+var list = [
+  if (a)
+    for (var b in c) thing,
+];
+>>> Don't force split outer when subelement is nested inside collection.
+var list = [
+  if (a) [for (var b in c) d]
+];
+<<<
+var list = [
+  if (a) [for (var b in c) d],
+];
 >>> Nested if inside list doesn't force outer if to split.
 var list = [if (a) [if (b) c]];
 <<<

test/expression/collection_spread.stmt

@@ -52,4 +52,14 @@ var list = [
     yield thing;
   }(),
   4,
+];
+>>> Spread cascade.
+var list = [1, ...thing..cascade()..another(), 4];
+<<<
+var list = [
+  1,
+  ...thing
+    ..cascade()
+    ..another(),
+  4,
 ];

test/expression/list.stmt

@@ -116,4 +116,15 @@ thirdElement];
       AnotherLongTypeName
     >
   >
->[1, 2, 3];
+>[1, 2, 3];
+>>> Force split because of contained block.
+[first, () {"fn";},third,fourth];
+<<<
+[
+  first,
+  () {
+    "fn";
+  },
+  third,
+  fourth,
+];

test/expression/map.stmt

@@ -138,4 +138,14 @@ const {first: 1, second: 2};
     VeryLongTypeName,
     AnotherLongTypeName
   >
->{1: 'one', 2: 'two'};
+>{1: 'one', 2: 'two'};
+>>> Force split because of contained block.
+var m = {first: 1, fn: () {"fn";},third:fourth};
+<<<
+var m = {
+  first: 1,
+  fn: () {
+    "fn";
+  },
+  third: fourth,
+};

test/expression/map_comment.stmt

@@ -9,10 +9,17 @@ var map = {
 var map = {
   // comment
 };
->>> Inline block comment.
+>>> Inline block comment in empty map.
 var map = {  /* comment */  };
 <<<
 var map = {/* comment */};
+>>> Inline block comment after entry.
+var map = {first: one /* bang */, second: two};
+<<<
+var map = {
+  first: one /* bang */,
+  second: two,
+};
 >>> After entry.
 ({key: value // comment
 });

test/expression/record.stmt

@@ -117,3 +117,14 @@ var record = (
     veryLongElement__________,
   ),
 );
+>>> Force split because of contained block.
+(first, () {"fn";},third,fourth);
+<<<
+(
+  first,
+  () {
+    "fn";
+  },
+  third,
+  fourth,
+);

test/expression/set.stmt

@@ -33,4 +33,17 @@ var set =
         Fifth,
         Sixth
       >
-    >{};
+    >{};
+>>> Force split because of contained block.
+var s = {first, 1, fn, () {"fn";},third,fourth};
+<<<
+var s = {
+  first,
+  1,
+  fn,
+  () {
+    "fn";
+  },
+  third,
+  fourth,
+};