Skip to content

Add more robust way of invoking flutter/dart tools from tests #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakemac53 opened this issue Apr 4, 2025 · 2 comments · May be fixed by #143
Open

Add more robust way of invoking flutter/dart tools from tests #33

jakemac53 opened this issue Apr 4, 2025 · 2 comments · May be fixed by #143

Comments

@jakemac53
Copy link
Contributor

Today the tests just assume dart and flutter are on your PATH. We should probably support something more robust than that though.

@kenzieschmoll
Copy link
Contributor

On the DevTools CI, we clone the Flutter SDK in a flutter-prep step that is cached for all actions jobs: https://github.com/flutter/devtools/blob/master/.github/workflows/flutter-prep.yaml#L57

@jakemac53
Copy link
Contributor Author

jakemac53 commented Apr 7, 2025

Fwiw the current solution (using the third party flutter action) actually works perfectly fine for CI as it does ensure these things exist on your PATH.

The issue would come up for local development, it might not work for all people and if you want to run the tests against a custom local version of flutter there isn't support for that.

@jakemac53 jakemac53 self-assigned this May 23, 2025
@jakemac53 jakemac53 linked a pull request May 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants