#252: Fixed Rector configuration and applied Rector

Author: raymondschouten

rector.php

@@ -12,8 +12,8 @@
         __DIR__ . '/tests',
     ])
     ->withSets([
-        LevelSetList::UP_TO_PHP_80,
-        SymfonySetList::SYMFONY_60,
+        LevelSetList::UP_TO_PHP_81,
+        SymfonySetList::SYMFONY_61,
     ])
     ->withImportNames(
         importShortClasses: false,

src/BooleanToValueTransformer.php

@@ -38,9 +38,9 @@ class BooleanToValueTransformer implements DataTransformerInterface
 {
     public function __construct(
         /** @var R */
-        private string|int|float|bool $trueValue = true,
+        private readonly string|int|float|bool $trueValue = true,
         /** @var R */
-        private string|int|float|bool $falseValue = false
+        private readonly string|int|float|bool $falseValue = false
     ) {
     }
 

src/EntityToIdentifierTransformer.php

@@ -48,16 +48,16 @@
 class EntityToIdentifierTransformer implements DataTransformerInterface
 {
     /** @var class-string<T> */
-    private string $className;
+    private readonly string $className;
     /** @var ObjectRepository<T> */
-    private ObjectRepository $repository;
-    private ClassMetadata $metadata;
+    private readonly ObjectRepository $repository;
+    private readonly ClassMetadata $metadata;
 
     /**
      * @param class-string<T> $className
      */
     public function __construct(
-        private ObjectManager $entityManager,
+        private readonly ObjectManager $entityManager,
         string $className
     ) {
         $this->repository = $this->entityManager->getRepository($className);

tests/EntityToIdentifierTransformerTest.php

@@ -69,8 +69,8 @@ protected function setUp(): void
         $this->entityManager->method('getRepository')->willReturn($this->repository);
         $this->entityManager->method('getClassMetadata')->willReturn($this->metadata);
 
-        $this->metadata->method('getName')->willReturnCallback([$this, 'getClassName']);
-        $this->metadata->method('getIdentifierValues')->willReturnCallback([$this, 'getIdentifier']);
+        $this->metadata->method('getName')->willReturnCallback($this->getClassName(...));
+        $this->metadata->method('getIdentifierValues')->willReturnCallback($this->getIdentifier(...));
     }
 
     public function getClassName(): string