Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent conflicts of type names #4783

Closed
StachuDotNet opened this issue Mar 9, 2023 · 3 comments
Closed

Prevent conflicts of type names #4783

StachuDotNet opened this issue Mar 9, 2023 · 3 comments

Comments

@StachuDotNet
Copy link
Member

StachuDotNet commented Mar 9, 2023 •
edited
Loading

e.g. users shouldn't be allowed to define a List type - right?

In addition to prevent conflicts of existing types, it might be worth considering preventing conflicts with some set of "reserved" types (e.g. Set)
@pbiggar
Copy link
Member

pbiggar commented Sep 20, 2023

I think this is handled - users can't have Builtin.List?

@StachuDotNet
Copy link
Member Author

I don't think there's anything preventing a user from defining a Builtin module in userspace currently, and/or a List module within that. It's true that the current NameResolver will use anything in the builtins before trying to use anything in a user-defined Builtin module.

The call-out I intended with this issue is that we should maybe warn/error at definition of such a module? I think this is part of a larger "what do we do with keywords and reserved names?" story

@StachuDotNet StachuDotNet added later Let's think about this later -- we have some higher-priority things to work through first needs-review I plan on going through each of the issues and clarifying them -- this is to mark remaining issues labels Feb 8, 2024
@StachuDotNet
Copy link
Member Author

folded into #5259

@StachuDotNet StachuDotNet removed later Let's think about this later -- we have some higher-priority things to work through first needs-review I plan on going through each of the issues and clarifying them -- this is to mark remaining issues labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pbiggar @StachuDotNet