From 6229c18ce460d8bef08f65ec969e8c8c6253b0ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niccol=C3=B2=20Belli?= <niccolo.belli@linuxsystems.it>
Date: Tue, 5 Dec 2023 11:09:21 +0100
Subject: [PATCH] fix: collection filtering condition (#13)

---
 .changeset/yellow-wolves-invent.md  | 5 +++++
 packages/find/src/findDataloader.ts | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/yellow-wolves-invent.md

diff --git a/.changeset/yellow-wolves-invent.md b/.changeset/yellow-wolves-invent.md
new file mode 100644
index 0000000..d6723a7
--- /dev/null
+++ b/.changeset/yellow-wolves-invent.md
@@ -0,0 +1,5 @@
+---
+"mikro-orm-find-dataloader": patch
+---
+
+fix: collection filtering condition
diff --git a/packages/find/src/findDataloader.ts b/packages/find/src/findDataloader.ts
index e67490b..38d8716 100644
--- a/packages/find/src/findDataloader.ts
+++ b/packages/find/src/findDataloader.ts
@@ -490,7 +490,9 @@ export function getFindBatchLoadFn<Entity extends object>(
         } else {
           // Our current filter is an object
           if (entityValue instanceof Collection) {
-            entityValue.find((entity) => filterResult(entity, value));
+            if (!entityValue.getItems().some((entity) => filterResult(entity, value))) {
+              return false;
+            }
           } else if (!filterResult(entityValue as object, value)) {
             return false;
           }