Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting updates on the doc of DSChiefApprovals.etch #16

Open
DocCon-team opened this issue May 15, 2022 · 0 comments
Open

Suggesting updates on the doc of DSChiefApprovals.etch #16

DocCon-team opened this issue May 15, 2022 · 0 comments

Comments

@DocCon-team
Copy link

Hi,

The function DSChiefApprovals.etch emits an event Etch, which is not documented in the README doc.

emit Etch(hash);

A potential fix could be adding the description "Emits an Etch event" to the README doc.

Furthermore, function DSChiefApprovals.vote calls the etch function. So it emits the Etch event as well.

bytes32 slate = etch(yays);

A potential fix could also be adding the description "Emits an Etch event" to this function in the README doc.

Could you please check it?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant