selfcheck

Author: danmar

gui/resultstree.cpp

@@ -935,7 +935,7 @@ void ResultsTree::hideResult()
     if (!mSelectionModel)
         return;
     bool hide = false;
-    for (QModelIndex index : mSelectionModel->selectedRows()) {
+    for (const QModelIndex& index : mSelectionModel->selectedRows()) {
         ResultItem *item = dynamic_cast<ResultItem*>(mModel->itemFromIndex(index));
         if (item && item->getType() == ResultItem::Type::message)
             hide = item->hidden = true;
@@ -952,7 +952,7 @@ void ResultsTree::recheckSelectedFiles()
         return;
 
     QStringList selectedItems;
-    for (QModelIndex index : mSelectionModel->selectedRows()) {
+    for (const QModelIndex& index : mSelectionModel->selectedRows()) {
         const ResultItem *item = dynamic_cast<ResultItem*>(mModel->itemFromIndex(index));
         while (item->parent())
             item = dynamic_cast<const ResultItem*>(item->parent());
@@ -1000,7 +1000,7 @@ void ResultsTree::suppressSelectedIds()
         return;
 
     QSet<QString> selectedIds;
-    for (QModelIndex index : mSelectionModel->selectedRows()) {
+    for (const QModelIndex& index : mSelectionModel->selectedRows()) {
         const ResultItem *item = dynamic_cast<ResultItem*>(mModel->itemFromIndex(index));
         if (!item || item->getType() == ResultItem::Type::file || !item->errorItem)
             continue;
@@ -1178,13 +1178,12 @@ void ResultsTree::updateFromOldReport(const QString &filename)
             if (!error)
                 // FIXME..
                 continue;
-            const ErrorItem* oldError = nullptr;
-            for (const ErrorItem& err: oldErrors) {
-                if (ErrorItem::same(err, *error->errorItem)) {
-                    oldError = &err;
-                    break;
-                }
-            }
+            const auto it = std::find_if(oldErrors.cbegin(),
+                                         oldErrors.cend(),
+                                         [error](const ErrorItem& err) {
+                return ErrorItem::same(err, *error->errorItem);
+            });
+            const ErrorItem* oldError = (it == oldErrors.cend()) ? nullptr : &*it;
 
             // New error .. set the "sinceDate" property
             if (oldError && !oldError->sinceDate.isEmpty()) {