Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates available #3

Closed
fredZen opened this issue Jul 25, 2017 · 1 comment · Fixed by #4
Closed

Updates available #3

fredZen opened this issue Jul 25, 2017 · 1 comment · Fixed by #4

Comments

@fredZen
Copy link
Contributor

fredZen commented Jul 25, 2017

Hi again

I wanted to use this with a recent version of Sente, so I ported the example. Then I did some more component-izing, because I didn’t really like the idea of the server accesing the system through a global var. Only then did I discover that this project had been deprecated in favor of system-websocket.

Anyway, here are the changes I made to sente-system:

  1. Added a deprecation notice to the README file
  2. Re-synced with the upstream demo from Sente
  3. Componentized the server

Would you be interested in me issuing a pull-request for either of these?

@danielsz
Copy link
Owner

Hi Fred,

Looks great. I'll be very happy to take your PR. Thank you very much!

No need for 1, I'll restate the purpose of sente-boot, sente-system and system-websocket. Each has different knowledge requirements.
No need to know anything about system for sente-boot.

Now that you did this work on sente-system it will be more difficult to explain the difference between it and system-websocket, but that's a good problem to have :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants