Skip to content

Commit d9cb5c9

Browse files
author
Nicolas Ollinger
committed
fix version numbers + help message + open notess
1 parent 8e8bfa8 commit d9cb5c9

File tree

2 files changed

+23
-9
lines changed

2 files changed

+23
-9
lines changed

classic/rise/static/main.js

+18-4
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,10 @@ define([
728728
'colorNext': () => RevealChalkboard.colorNext(), // next color
729729
'colorPrev': () => RevealChalkboard.colorPrev(), // previous color
730730
'download': () => RevealChalkboard.download() // download recorded chalkboard drawing
731-
}
731+
},
732+
'notes': { // API calls for RevealNotes plug-in
733+
'openNotes' : () => RevealNotes.open(), // open speaker notes window
734+
},
732735
}
733736

734737
let reveal_helpstr = {
@@ -748,7 +751,10 @@ define([
748751
'colorNext': 'cycle to next pen color',
749752
'colorPrev': 'cycle to previous pen color',
750753
'download': 'download recorded chalkboard drawing'
751-
}
754+
},
755+
'notes': { // API calls for RevealNotes plug-in
756+
'openNotes' : 'open speaker notes windows'
757+
},
752758
}
753759

754760
// need to check, if we can fetch the default bindings from rise.yaml (nbconfig)
@@ -769,7 +775,10 @@ define([
769775
'colorPrev': 'q', // keycode 81
770776
'colorNext': 's', // kecode 83
771777
'download': '\\' // keycode 220
772-
}
778+
},
779+
'notes': { // API calls for RevealNotes plug-in
780+
'openNotes' : 't' // keycode 84
781+
},
773782
}
774783

775784
// update reveal bindings with custom key codes
@@ -874,6 +883,7 @@ define([
874883
let jupyter_keys;
875884
let reveal_keys;
876885
let cb_keys;
886+
let no_keys;
877887

878888
//check if custom bindings for registered jupyter calls are defined
879889
if (typeof complete_config.shortcuts !== 'undefined'){
@@ -889,8 +899,10 @@ define([
889899

890900
reveal_keys = updated_keybindings['main'];
891901
cb_keys = updated_keybindings['chalkboard'];
902+
no_keys = updated_keybindings['notes'];
892903
let reveal_help = reveal_helpstr['main'];
893904
let cb_help = reveal_helpstr['chalkboard'];
905+
let no_help= reveal_helpstr['notes'];
894906

895907
let message = $('<div/>').append(
896908
$("<p/></p>").addClass('dialog').html(
@@ -903,7 +915,7 @@ define([
903915
helpListItem(reveal_keys.firstSlide, reveal_help.firstSlide) +
904916
helpListItem(reveal_keys.lastSlide, reveal_help.lastSlide) +
905917
helpListItem(reveal_keys.toggleOverview, reveal_help.toggleOverview) +
906-
helpListItem('t', 'toggle notes') +
918+
helpListItem(no_keys.openNotes, no_help.openNotes) +
907919
`<li><kbd>,</kbd>: ${reveal_help.toggleAllRiseButtons}</li>` +
908920
"<li><kbd>/</kbd>: black screen</li>" +
909921
"<li><strong>less useful:</strong>" +
@@ -917,6 +929,8 @@ define([
917929
"<ul>" +
918930
helpListItem(cb_keys.toggleChalkboard, cb_help.toggleChalkboard) +
919931
helpListItem(cb_keys.toggleNotesCanvas, cb_help.toggleNotesCanvaas) +
932+
helpListItem(cb_keys.colorNext, cb_help.colorNext) +
933+
helpListItem(cb_keys.colorPrev, cb_help.colorPrev) +
920934
helpListItem(cb_keys.download, cb_help.download) +
921935
helpListItem(cb_keys.reset, cb_help.reset) +
922936
helpListItem(cb_keys.clear, cb_help.clear) +

rise-reveal/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@
2828
"url": "https://github.com/damianavila/RISE/issues"
2929
},
3030
"files": [
31-
"export/reveal.js",
32-
"export/reveal.js-chalkboard"
31+
"export/reveal.js",
32+
"export/reveal.js-chalkboard"
3333
],
3434
"scripts": {
3535
"build": "for target in copy patch; do npm run $target; done",
36-
"copy": "mkdir -p export; for dep in reveal.js; do cp -r ./node_modules/$dep/ ./export/$dep/; done; cp -r ./node_modules/reveal.js-plugins/chalkboard ./export/reveal.js-chalkboard/",
36+
"copy": "mkdir -p export; cp -r ./node_modules/reveal.js/ ./export/reveal.js/; cp -r ./node_modules/reveal.js-plugins/chalkboard ./export/reveal.js-chalkboard/",
3737
"patch": "for target in patch-reveal-css patch-notes patch-themes patch-chalkboard ; do npm run $target; done",
3838
"patch-reveal-css": "sed -i.upstream '11 s_^_/*_' export/reveal.js/css/reveal.css",
3939
"patch-notes": "bash patch-notes-plugin.sh",
@@ -42,8 +42,8 @@
4242
"clean": "rm -rf node_modules export"
4343
},
4444
"dependencies": {
45-
"reveal.js": "~3.9.0",
45+
"reveal.js": "~3.9.2",
4646
"reveal.js-plugins": "rajgoel/reveal.js-plugins#3.9.0"
4747
},
48-
"version": "380.0.2"
48+
"version": "390.0.1"
4949
}

0 commit comments

Comments
 (0)