fix: Add IDisposable pattern to ElasticsearcheHealth (#1080)

Author: Spacemonkay

src/NetEvolve.HealthChecks.Elasticsearch/ElasticsearchHealthCheck.cs

@@ -2,18 +2,21 @@
 
 using System;
 using System.Collections.Concurrent;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 using Elastic.Clients.Elasticsearch;
+using Elastic.Clients.Elasticsearch.Graph;
 using Elastic.Transport;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Diagnostics.HealthChecks;
 using NetEvolve.Extensions.Tasks;
 using SourceGenerator.Attributes;
 
 [ConfigurableHealthCheck(typeof(ElasticsearchOptions))]
-internal sealed partial class ElasticsearchHealthCheck
+internal sealed partial class ElasticsearchHealthCheck : IDisposable
 {
     private ConcurrentDictionary<string, ElasticsearchClient>? _clients;
+    private bool _disposedValue;
 
     private async ValueTask<HealthCheckResult> ExecuteHealthCheckAsync(
         string name,
@@ -79,4 +82,27 @@ private static ElasticsearchClient CreateClient(ElasticsearchOptions options)
 
         return new ElasticsearchClient(settings);
     }
+
+    [SuppressMessage(
+        "Blocker Code Smell",
+        "S2953:Methods named \"Dispose\" should implement \"IDisposable.Dispose\"",
+        Justification = "As designed."
+    )]
+    private void Dispose(bool disposing)
+    {
+        if (!_disposedValue)
+        {
+            if (disposing && _clients is not null)
+            {
+                _clients.Clear();
+            }
+            _disposedValue = true;
+        }
+    }
+
+    void IDisposable.Dispose()
+    {
+        Dispose(disposing: true);
+        GC.SuppressFinalize(this);
+    }
 }

tests/NetEvolve.HealthChecks.Tests.Unit/Elasticsearch/ElasticsearchHealthCheckTests.cs

@@ -20,7 +20,7 @@ public async Task CheckHealthAsync_WhenContextNull_ThrowArgumentNullException()
         // Arrange
         var serviceProvider = Substitute.For<IServiceProvider>();
         var optionsMonitor = Substitute.For<IOptionsMonitor<ElasticsearchOptions>>();
-        var check = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
+        using var check = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
 
         // Act
         async Task Act() => _ = await check.CheckHealthAsync(null!, default);
@@ -37,7 +37,7 @@ public async Task CheckHealthAsync_WhenCancellationTokenIsCancelled_ShouldReturn
         var serviceProvider = Substitute.For<IServiceProvider>();
         var optionsMonitor = Substitute.For<IOptionsMonitor<ElasticsearchOptions>>();
 
-        var check = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
+        using var check = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
         var context = new HealthCheckContext
         {
             Registration = new HealthCheckRegistration(testName, check, null, null),
@@ -65,7 +65,7 @@ public async Task CheckHealthAsync_WhenOptionsAreNull_ShouldReturnUnhealthy()
         var serviceProvider = Substitute.For<IServiceProvider>();
         var optionsMonitor = Substitute.For<IOptionsMonitor<ElasticsearchOptions>>();
 
-        var check = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
+        using var check = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
         var context = new HealthCheckContext
         {
             Registration = new HealthCheckRegistration(testName, check, null, null),
@@ -112,7 +112,7 @@ public async Task CheckHealthAsync_WithKeyedService_ShouldUseKeyedService()
 
         var serviceProvider = new ServiceCollection().AddKeyedSingleton(serviceKey, client).BuildServiceProvider();
 
-        var healthCheck = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
+        using var healthCheck = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
         var context = new HealthCheckContext
         {
             Registration = new HealthCheckRegistration(
@@ -163,7 +163,7 @@ public async Task CheckHealthAsync_WithoutKeyedService_ShouldUseDefaultService()
 
         var serviceProvider = new ServiceCollection().AddSingleton(client).BuildServiceProvider();
 
-        var healthCheck = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
+        using var healthCheck = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
         var context = new HealthCheckContext
         {
             Registration = new HealthCheckRegistration(
@@ -214,7 +214,7 @@ public async Task CheckHealthAsync_WhenConnectionFails_ShouldReturnUnhealthy()
 
         var serviceProvider = new ServiceCollection().AddSingleton(client).BuildServiceProvider();
 
-        var healthCheck = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
+        using var healthCheck = new ElasticsearchHealthCheck(serviceProvider, optionsMonitor);
         var context = new HealthCheckContext
         {
             Registration = new HealthCheckRegistration(