Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedify node breaks favicon on terminal emulators without truecolor #168

Open
dahlia opened this issue Nov 22, 2024 · 0 comments
Open

fedify node breaks favicon on terminal emulators without truecolor #168

dahlia opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dahlia
Copy link
Owner

dahlia commented Nov 22, 2024

Currently the fedify node command breaks favicon on terminal emulators without 24-bit truecolor.1 Here's an example in macOS's built-in Terminal app, which doesn't support truecolor:

fedify node is broken on macOS's built-in Terminal app

For your information, it should be shown like below, which is taken in GNOME Terminal:

fedify node normally works on GNOME Terminal

We have two options to address it:

  1. Properly fix the favicon.

  2. Make it hide favicon at all.

    • Detect if the running terminal emulator supports truecolor.
    • If the terminal emulator does not support it, do not display favicon at all.

Footnotes

  1. Note that quite many terminal emulators do not support truecolor. See also Terminal Colors.

@dahlia dahlia added bug Something isn't working good first issue Good for newcomers labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant