-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Open
Labels
npm: @cypress/eslint-plugin-dev@cypress/eslint-plugin-dev package issues@cypress/eslint-plugin-dev package issuesprocess: dependenciesRelated to internal dependenciesRelated to internal dependenciestype: enhancementRequested enhancement of existing featureRequested enhancement of existing feature
Description
What would you like?
- Move Cypess ESLint Dev rules into the Cypress root and eliminate the need to maintain an internal & public package.
- Add scripts to repo root and lint rules to individual packages
- Update dependencies and stale issues
Why is this needed?
There are a few things that can be addressed:
- There is an internal ESLint plugin with rules shared across different entities. However it's published on npm (3,783 weekly DLs 🤔) in addition to the public version (2,378,591 weekly DLs).
- The internal version is a dependency and its rules are extended in the public version with additional custom rules.
- Some lint rules seem to be run at the root level across the Cypress repo, where adding scripts at the root to run lint rules in each lib could be more optimal.
- We could move the rules from the internal dev plugin into the rules at the repo root, remove the dev package and move the public version into the monorepo's npm packages to not be maintaining two and minimize confusion about which to use.
Also...
- Users have begun forking the public version to update & make improvements because the current package has gone stale.
- ESLint and supporting tooling is very outdated in the dev version, making authoring new rules with modern .js incompatible in the public version.
- There are dependencies in the public version that aren't being used and could use general cleanup and maintenance by way of Dependebot or Renovate so the outdated dependency issue is automated away.
Other
No response
brandonb927 and brycedewittjordanpowell88, askoufis and brycedewitt
Metadata
Metadata
Assignees
Labels
npm: @cypress/eslint-plugin-dev@cypress/eslint-plugin-dev package issues@cypress/eslint-plugin-dev package issuesprocess: dependenciesRelated to internal dependenciesRelated to internal dependenciestype: enhancementRequested enhancement of existing featureRequested enhancement of existing feature