Skip to content

Commit d475d20

Browse files
authored
chore: use browser tools to install chrome for testing (#31868)
1 parent ef1a73b commit d475d20

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

.circleci/workflows.yml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ chrome-beta-version: &chrome-beta-version "138.0.7204.15"
55
firefox-stable-version: &firefox-stable-version "137.0"
66

77
orbs:
8-
browser-tools: circleci/[email protected].0
8+
browser-tools: circleci/[email protected].1
99

1010
defaults: &defaults
1111
parallelism: 1
@@ -578,11 +578,6 @@ commands:
578578
description: whether or not to install google chrome for testing
579579
type: boolean
580580
default: false
581-
google-chrome-for-testing-channel:
582-
description: Google Chrome for Testing channel to install
583-
type: string
584-
# can be stable, beta, dev, or canary
585-
default: stable
586581
google-chrome-for-testing-version:
587582
description: Google Chrome for Testing version to install
588583
type: string
@@ -635,13 +630,13 @@ commands:
635630
equal: [ true, << parameters.install-chrome-for-testing >> ]
636631
steps:
637632
- run:
638-
name: Install Chrome for Testing and link it to google-chrome
633+
name: Install unzip
639634
command: |
640-
INSTALL_OUTPUT=$(npx @puppeteer/browsers install chrome@<<parameters.google-chrome-version>> --path /tmp/chrome-for-testing)
641-
DOWNLOAD_DIR=$(echo "$INSTALL_OUTPUT" | grep -o '\/.*\/chrome-linux64')
642-
mv $DOWNLOAD_DIR /opt/chrome-for-testing
643-
ln -fs /opt/chrome-for-testing/chrome /usr/local/bin/chrome
644-
rm -rf /tmp/chrome-for-testing
635+
apt-get update && apt-get install -y unzip
636+
- browser-tools/install_chrome_for_testing:
637+
version: << parameters.google-chrome-for-testing-version >>
638+
install_chromedriver: false
639+
645640
# This code builds better-sqlite3 on Debian 10 (Buster). This is necessary because Debian 10 has the oldest glibc version (2.28) that we support.
646641
#
647642
# Since this is running Docker remote (because the job running the command may not be using an executor with the appropriate glibc version), we need to

0 commit comments

Comments
 (0)