Skip to content

Commit 1b4ef5b

Browse files
cacieprinscypress-bot[bot]
andauthored
Updates v8 snapshots to fix windows build (#31918)
* use node 22 in the v8 snapshot update workflow * index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow * index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow * index on windows-v8-snapshots: a013464 use node 22 in the v8 snapshot update workflow * run workflows on windows/mac --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
1 parent e369875 commit 1b4ef5b

File tree

5 files changed

+89
-104
lines changed

5 files changed

+89
-104
lines changed

.circleci/workflows.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ macWorkflowFilters: &darwin-workflow-filters
5050
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
5151
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
5252
- equal: [ 'electron-36', << pipeline.git.branch >> ]
53+
- equal: [ 'windows-v8-snapshots', << pipeline.git.branch >> ]
5354
- matches:
5455
pattern: /^release\/\d+\.\d+\.\d+$/
5556
value: << pipeline.git.branch >>
@@ -61,6 +62,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
6162
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
6263
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
6364
- equal: [ 'electron-36', << pipeline.git.branch >> ]
65+
- equal: [ 'windows-v8-snapshots', << pipeline.git.branch >> ]
6466
- matches:
6567
pattern: /^release\/\d+\.\d+\.\d+$/
6668
value: << pipeline.git.branch >>
@@ -84,6 +86,7 @@ windowsWorkflowFilters: &windows-workflow-filters
8486
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
8587
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
8688
- equal: [ 'electron-36', << pipeline.git.branch >> ]
89+
- equal: [ 'windows-v8-snapshots', << pipeline.git.branch >> ]
8790
- matches:
8891
pattern: /^release\/\d+\.\d+\.\d+$/
8992
value: << pipeline.git.branch >>

.github/workflows/update_v8_snapshot_cache.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888
- name: Set up Node.js
8989
uses: actions/setup-node@v4
9090
with:
91-
node-version: 20
91+
node-version: 22
9292
cache: 'yarn'
9393
- name: Run yarn
9494
# set the timeout here to try and deal with Windows slowness

0 commit comments

Comments
 (0)