Commit 7ff6ea2
docs(principles): turn feedback into reusable rules (#672)
* docs(principles): add maintenance guide (vetting + living-document loop)
Houses the methodology that was removed from cypress-io/cypress.io's
design-system-access.md (which is now access-only): how to vet feedback
framed as a principle (sounds-principled-but-isn't / conflicts / additive),
and the living-document loop for adding principles. Direct-to-canon via PR;
no separate staging log.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* docs(principles): reframe as learning-from-feedback; link from index
- Rename principles/README.md → principles/learning-from-feedback.md so agents discover it by topic, not by folder convention.
- Add "Notice → Extract → Test → Codify" loop at the top so the trigger is every piece of feedback, not just feedback framed as a principle.
- Link from .agents/index.md under Principles and cross-link from feedback.md.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs(principles): apply Ryan's review feedback; refresh cy-review-pr-comments
Principles
- learning-from-feedback.md: name the sources of feedback up top (teammates, other agents, Copilot, automation). Rewrite Extract so the agent asks the human for the *why* behind a fix and turns that answer into the rule. Reframe the verbatim quote as a live confirmation with the human during review/reply — not an internal check.
- index.md: strengthen the trigger so an agent fetches this on every feedback exchange, not only when "principle" is named.
- feedback.md: same trigger language on the cross-link.
Skill
- cy-review-pr-comments.md: port the cypress.io version's improvements — fetch from any author (not just Copilot), Step 4.5 sign-off before executing, reply-then-resolve back-to-back per thread, hard-stop conditions for Copilot loops. Keep cypress-design's repo policies and known-issues.md path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent 9a4aeaa commit 7ff6ea2
4 files changed
Lines changed: 206 additions & 65 deletions
File tree
- .agents
- principles
- skills
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
0 commit comments