Skip to content

Commit b192975

Browse files
mercihabamBaraka24
authored andcommitted
fix(backend): address potential security exploits in request parameters (#1514)
* use FILTER_SANITIZE_FULL_SPECIAL_CHARS for all get request parameters instead of FILTER_DEFAULT and fix duplicate post filters of the contact module * for all other parameters, use FILTER_UNSAFE_RAW instead of FILTER_DEFAULT for better clarity
1 parent 8cada02 commit b192975

File tree

32 files changed

+337
-331
lines changed

32 files changed

+337
-331
lines changed

modules/2fa/setup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
'ajax_2fa_setup_check',
2424
),
2525
'allowed_post' => array(
26-
'2fa_code' => FILTER_DEFAULT,
26+
'2fa_code' => FILTER_UNSAFE_RAW,
2727
'2fa_enable' => FILTER_VALIDATE_INT,
2828
'2fa_backup_codes' => array('filter' => FILTER_VALIDATE_INT, 'flags' => FILTER_FORCE_ARRAY)
2929
),

modules/account/setup.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@
3131
'change_password'
3232
),
3333
'allowed_post' => array(
34-
'create_username' => FILTER_DEFAULT,
34+
'create_username' => FILTER_UNSAFE_RAW,
3535
'create_password' => FILTER_UNSAFE_RAW,
3636
'create_password_again' => FILTER_UNSAFE_RAW,
37-
'delete_username' => FILTER_DEFAULT,
37+
'delete_username' => FILTER_UNSAFE_RAW,
3838
'new_pass1' => FILTER_UNSAFE_RAW,
3939
'new_pass2' => FILTER_UNSAFE_RAW,
4040
'old_pass' => FILTER_UNSAFE_RAW,
41-
'change_password' => FILTER_DEFAULT,
41+
'change_password' => FILTER_UNSAFE_RAW,
4242
)
4343
);

modules/advanced_search/setup.php

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,16 @@
3131
'ajax_adv_search'
3232
),
3333
'allowed_post' => array(
34-
'adv_source' => FILTER_DEFAULT,
35-
'adv_start' => FILTER_DEFAULT,
34+
'adv_source' => FILTER_UNSAFE_RAW,
35+
'adv_start' => FILTER_UNSAFE_RAW,
3636
'adv_source_limit' => FILTER_VALIDATE_INT,
37-
'adv_end' => FILTER_DEFAULT,
38-
'adv_charset' => FILTER_DEFAULT,
39-
'adv_flags' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_REQUIRE_ARRAY),
40-
'adv_terms' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_REQUIRE_ARRAY),
41-
'adv_targets' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_REQUIRE_ARRAY),
37+
'adv_end' => FILTER_UNSAFE_RAW,
38+
'adv_charset' => FILTER_UNSAFE_RAW,
39+
'adv_flags' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_REQUIRE_ARRAY),
40+
'adv_terms' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_REQUIRE_ARRAY),
41+
'adv_targets' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_REQUIRE_ARRAY),
42+
'all_folders' => FILTER_VALIDATE_BOOLEAN,
43+
'all_special_folders' => FILTER_VALIDATE_BOOLEAN,
44+
'include_subfolders' => FILTER_VALIDATE_BOOLEAN,
4245
)
4346
);

modules/api_login/setup.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
return array(
1414
'allowed_pages' => array('process_api_login'),
1515
'allowed_post' => array(
16-
'hm_session' => FILTER_DEFAULT,
17-
'hm_id' => FILTER_DEFAULT,
18-
'api_login_key' => FILTER_DEFAULT
16+
'hm_session' => FILTER_UNSAFE_RAW,
17+
'hm_id' => FILTER_UNSAFE_RAW,
18+
'api_login_key' => FILTER_UNSAFE_RAW
1919
)
2020
);

modules/calendar/setup.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@
2222
'calendar',
2323
),
2424
'allowed_post' => array(
25-
'event_title' => FILTER_DEFAULT,
26-
'event_detail' => FILTER_DEFAULT,
27-
'event_date' => FILTER_DEFAULT,
28-
'event_time' => FILTER_DEFAULT,
29-
'event_repeat' => FILTER_DEFAULT,
30-
'delete_id' => FILTER_DEFAULT
25+
'event_title' => FILTER_UNSAFE_RAW,
26+
'event_detail' => FILTER_UNSAFE_RAW,
27+
'event_date' => FILTER_UNSAFE_RAW,
28+
'event_time' => FILTER_UNSAFE_RAW,
29+
'event_repeat' => FILTER_UNSAFE_RAW,
30+
'delete_id' => FILTER_UNSAFE_RAW
3131
),
3232
'allowed_get' => array(
33-
'date' => FILTER_DEFAULT,
34-
'view' => FILTER_DEFAULT,
35-
'action' => FILTER_DEFAULT,
33+
'date' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
34+
'view' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
35+
'action' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
3636
),
3737
);

modules/carddav_contacts/setup.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424

2525
return array(
2626
'allowed_post' => array(
27-
'carddav_usernames' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_FORCE_ARRAY),
27+
'carddav_usernames' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_FORCE_ARRAY),
2828
'carddav_passwords' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_FORCE_ARRAY),
29-
'carddav_email' => FILTER_DEFAULT,
30-
'carddav_fn' => FILTER_DEFAULT,
31-
'carddav_phone' => FILTER_DEFAULT,
32-
'carddav_phone_id' => FILTER_DEFAULT,
33-
'carddav_fn_id' => FILTER_DEFAULT,
34-
'carddav_email_id' => FILTER_DEFAULT
29+
'carddav_email' => FILTER_UNSAFE_RAW,
30+
'carddav_fn' => FILTER_UNSAFE_RAW,
31+
'carddav_phone' => FILTER_UNSAFE_RAW,
32+
'carddav_phone_id' => FILTER_UNSAFE_RAW,
33+
'carddav_fn_id' => FILTER_UNSAFE_RAW,
34+
'carddav_email_id' => FILTER_UNSAFE_RAW
3535
)
3636
);

modules/contacts/setup.php

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -64,39 +64,30 @@
6464
'ajax_autocomplete_contact'
6565
),
6666
'allowed_post' => array(
67-
'contact_email' => FILTER_DEFAULT,
68-
'contact_name' => FILTER_DEFAULT,
69-
'contact_phone' => FILTER_DEFAULT,
70-
'contact_id' => FILTER_DEFAULT,
71-
'contact_value' => FILTER_DEFAULT,
72-
'edit_contact' => FILTER_DEFAULT,
73-
'add_contact' => FILTER_DEFAULT,
74-
'contact_source' => FILTER_DEFAULT,
75-
'contact_type' => FILTER_DEFAULT,
76-
'import_contact' => FILTER_DEFAULT,
77-
'contact_email' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
78-
'contact_name' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
79-
'contact_phone' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
80-
'contact_group' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
81-
'contact_value' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
82-
'edit_contact' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
83-
'add_contact' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
84-
'contact_source' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
85-
'contact_type' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
67+
'contact_email' => FILTER_SANITIZE_EMAIL,
68+
'contact_name' => FILTER_UNSAFE_RAW,
69+
'contact_phone' => FILTER_UNSAFE_RAW,
70+
'contact_id' => FILTER_UNSAFE_RAW,
71+
'contact_value' => FILTER_UNSAFE_RAW,
72+
'edit_contact' => FILTER_UNSAFE_RAW,
73+
'add_contact' => FILTER_UNSAFE_RAW,
74+
'contact_source' => FILTER_UNSAFE_RAW,
75+
'contact_type' => FILTER_UNSAFE_RAW,
76+
'import_contact' => FILTER_UNSAFE_RAW,
8677
'contact_auto_collect' => FILTER_VALIDATE_BOOLEAN,
8778
'enable_warn_contacts_cc_not_exist_in_list_contact' => FILTER_VALIDATE_INT,
88-
'email_address' => FILTER_SANITIZE_FULL_SPECIAL_CHARS
79+
'email_address' => FILTER_SANITIZE_EMAIL
8980
),
9081
'allowed_get' => array(
9182
'contact_id' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
9283
'contact_page' => FILTER_VALIDATE_INT,
93-
'contact_type' => FILTER_DEFAULT,
94-
'contact_source' => FILTER_DEFAULT,
95-
'import_contact' => FILTER_DEFAULT,
84+
'contact_type' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
85+
'contact_source' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
86+
'import_contact' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
9687
),
9788
'allowed_output' => array(
9889
'contact_deleted' => array(FILTER_VALIDATE_INT, false),
99-
'imported_contact' => array(FILTER_DEFAULT, FILTER_REQUIRE_ARRAY),
90+
'imported_contact' => array(FILTER_SANITIZE_FULL_SPECIAL_CHARS, FILTER_REQUIRE_ARRAY),
10091
'contact_suggestions' => array(FILTER_SANITIZE_FULL_SPECIAL_CHARS, FILTER_REQUIRE_ARRAY),
10192
'collect_contacts' => array(FILTER_VALIDATE_BOOLEAN, false),
10293
'imap_allow_images' => array(FILTER_VALIDATE_BOOLEAN, false),

modules/core/setup.php

Lines changed: 83 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -204,138 +204,144 @@
204204
'ajax_quick_servers_setup',
205205
),
206206
'allowed_output' => array(
207-
'date' => array(FILTER_DEFAULT, false),
207+
'date' => array(FILTER_UNSAFE_RAW, false),
208208
'formatted_folder_list' => array(FILTER_UNSAFE_RAW, false),
209-
'router_user_msgs' => array(FILTER_DEFAULT, FILTER_REQUIRE_ARRAY),
209+
'router_user_msgs' => array(FILTER_UNSAFE_RAW, FILTER_REQUIRE_ARRAY),
210210
'router_login_state' => array(FILTER_VALIDATE_BOOLEAN, false),
211211
'formatted_message_list' => array(FILTER_UNSAFE_RAW, FILTER_REQUIRE_ARRAY),
212212
'just_saved_credentials' => array(FILTER_VALIDATE_BOOLEAN, false),
213213
'just_forgot_credentials' => array(FILTER_VALIDATE_BOOLEAN, false),
214-
'deleted_server_id' => array(FILTER_DEFAULT, false),
214+
'deleted_server_id' => array(FILTER_UNSAFE_RAW, false),
215215
'msg_headers' => array(FILTER_UNSAFE_RAW, false),
216216
'msg_text' => array(FILTER_UNSAFE_RAW, false),
217217
'msg_source' => array(FILTER_UNSAFE_RAW, false),
218218
'msg_parts' => array(FILTER_UNSAFE_RAW, false),
219-
'page_links' => array(FILTER_UNSAFE_RAW, false),
220-
'folder_status' => array(FILTER_DEFAULT, FILTER_REQUIRE_ARRAY),
221-
'imap_server_id' => array(FILTER_DEFAULT, false),
222-
'imap_service_name' => array(FILTER_DEFAULT, false),
219+
'pages' => array(FILTER_VALIDATE_INT, false),
220+
'folder_status' => array(FILTER_UNSAFE_RAW, FILTER_REQUIRE_ARRAY),
221+
'imap_server_id' => array(FILTER_UNSAFE_RAW, false),
222+
'imap_service_name' => array(FILTER_UNSAFE_RAW, false)
223223
),
224224
'allowed_cookie' => array(
225-
'CYPHTID' => FILTER_DEFAULT,
226-
'hm_id' => FILTER_DEFAULT,
227-
'hm_session' => FILTER_DEFAULT,
228-
'hm_msgs' => FILTER_DEFAULT,
225+
'CYPHTID' => FILTER_UNSAFE_RAW,
226+
'hm_id' => FILTER_UNSAFE_RAW,
227+
'hm_session' => FILTER_UNSAFE_RAW,
228+
'hm_msgs' => FILTER_UNSAFE_RAW,
229229
'hm_reload_folders' => FILTER_VALIDATE_INT
230230
),
231231
'allowed_server' => array(
232-
'REQUEST_URI' => FILTER_DEFAULT,
233-
'REQUEST_METHOD' => FILTER_DEFAULT,
232+
'REQUEST_URI' => FILTER_UNSAFE_RAW,
233+
'REQUEST_METHOD' => FILTER_UNSAFE_RAW,
234234
'SERVER_ADDR' => FILTER_VALIDATE_IP,
235235
'REMOTE_ADDR' => FILTER_VALIDATE_IP,
236236
'SERVER_PORT' => FILTER_VALIDATE_INT,
237-
'SERVER_PROTOCOL' => FILTER_DEFAULT,
238-
'PHP_SELF' => FILTER_DEFAULT,
239-
'REQUEST_SCHEME' => FILTER_DEFAULT,
240-
'HTTP_HOST' => FILTER_DEFAULT,
237+
'SERVER_PROTOCOL' => FILTER_UNSAFE_RAW,
238+
'PHP_SELF' => FILTER_UNSAFE_RAW,
239+
'REQUEST_SCHEME' => FILTER_UNSAFE_RAW,
240+
'HTTP_HOST' => FILTER_UNSAFE_RAW,
241241
'HTTP_ORIGIN' => FILTER_VALIDATE_URL,
242242
'HTTP_REFERER' => FILTER_VALIDATE_URL,
243-
'HTTP_ACCEPT_LANGUAGE' => FILTER_DEFAULT,
244-
'HTTP_ACCEPT_ENCODING' => FILTER_DEFAULT,
245-
'HTTP_ACCEPT_CHARSET' => FILTER_DEFAULT,
246-
'HTTP_ACCEPT' => FILTER_DEFAULT,
247-
'HTTP_USER_AGENT' => FILTER_DEFAULT,
248-
'HTTPS' => FILTER_DEFAULT,
249-
'SERVER_NAME' => FILTER_DEFAULT,
250-
'HTTP_X_REQUESTED_WITH' => FILTER_DEFAULT,
251-
'HTTP_X_FORWARDED_HOST' => FILTER_DEFAULT
243+
'HTTP_ACCEPT_LANGUAGE' => FILTER_UNSAFE_RAW,
244+
'HTTP_ACCEPT_ENCODING' => FILTER_UNSAFE_RAW,
245+
'HTTP_ACCEPT_CHARSET' => FILTER_UNSAFE_RAW,
246+
'HTTP_ACCEPT' => FILTER_UNSAFE_RAW,
247+
'HTTP_USER_AGENT' => FILTER_UNSAFE_RAW,
248+
'HTTPS' => FILTER_UNSAFE_RAW,
249+
'SERVER_NAME' => FILTER_UNSAFE_RAW,
250+
'HTTP_X_REQUESTED_WITH' => FILTER_UNSAFE_RAW,
251+
'HTTP_X_FORWARDED_HOST' => FILTER_UNSAFE_RAW
252252
),
253253

254254
'allowed_get' => array(
255-
'page' => FILTER_DEFAULT,
256-
'msgs' => FILTER_DEFAULT,
257-
'list_path' => FILTER_DEFAULT,
258-
'list_parent' => FILTER_DEFAULT,
255+
'page' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
256+
'msgs' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
257+
'list_path' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
258+
'list_parent' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
259259
'list_page' => FILTER_VALIDATE_INT,
260-
'uid' => FILTER_DEFAULT,
260+
'uid' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
261261
'search_terms' => FILTER_UNSAFE_RAW,
262-
'search_since' => FILTER_DEFAULT,
263-
'search_fld' => FILTER_DEFAULT,
264-
'filter' => FILTER_DEFAULT,
265-
'sort' => FILTER_DEFAULT,
266-
'keyword' => FILTER_DEFAULT,
267-
'screen_emails' => FILTER_DEFAULT,
262+
'search_since' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
263+
'search_fld' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
264+
'filter' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
265+
'sort' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
266+
'keyword' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
267+
'screen_emails' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
268268
),
269269

270270
'allowed_post' => array(
271-
'payload' => FILTER_DEFAULT,
272-
'reset_factory' => FILTER_DEFAULT,
273-
'hm_page_key' => FILTER_DEFAULT,
271+
'payload' => FILTER_UNSAFE_RAW,
272+
'reset_factory' => FILTER_UNSAFE_RAW,
273+
'hm_page_key' => FILTER_UNSAFE_RAW,
274274
'logout' => FILTER_VALIDATE_BOOLEAN,
275275
'save_and_logout' => FILTER_VALIDATE_BOOLEAN,
276276
'limit' => FILTER_VALIDATE_INT,
277-
'username' => FILTER_DEFAULT,
277+
'username' => FILTER_UNSAFE_RAW,
278278
'show_list_icons' => FILTER_VALIDATE_BOOLEAN,
279279
'password' => FILTER_UNSAFE_RAW,
280-
'hm_ajax_hook' => FILTER_DEFAULT,
281-
'save_settings' => FILTER_DEFAULT,
282-
'save_settings_permanently' => FILTER_DEFAULT,
283-
'save_settings_permanently_then_logout' => FILTER_DEFAULT,
284-
'language' => FILTER_DEFAULT,
280+
'hm_ajax_hook' => FILTER_UNSAFE_RAW,
281+
'save_settings' => FILTER_UNSAFE_RAW,
282+
'save_settings_permanently' => FILTER_UNSAFE_RAW,
283+
'save_settings_permanently_then_logout' => FILTER_UNSAFE_RAW,
284+
'language' => FILTER_UNSAFE_RAW,
285285
'flagged_per_source' => FILTER_VALIDATE_INT,
286-
'flagged_since' => FILTER_DEFAULT,
286+
'flagged_since' => FILTER_UNSAFE_RAW,
287287
'unread_per_source' => FILTER_VALIDATE_INT,
288-
'unread_since' => FILTER_DEFAULT,
288+
'unread_since' => FILTER_UNSAFE_RAW,
289289
'all_email_per_source' => FILTER_VALIDATE_INT,
290-
'all_email_since' => FILTER_DEFAULT,
290+
'all_email_since' => FILTER_UNSAFE_RAW,
291291
'all_per_source' => FILTER_VALIDATE_INT,
292-
'all_since' => FILTER_DEFAULT,
292+
'all_since' => FILTER_UNSAFE_RAW,
293293
'no_folder_icons' => FILTER_VALIDATE_BOOLEAN,
294294
'mailto_handler' => FILTER_VALIDATE_BOOLEAN,
295-
'list_style' => FILTER_DEFAULT,
296-
'timezone' => FILTER_DEFAULT,
295+
'list_style' => FILTER_UNSAFE_RAW,
296+
'timezone' => FILTER_UNSAFE_RAW,
297297
'disable_delete_prompt' => FILTER_VALIDATE_INT,
298298
'allow_delete_attachment' => FILTER_VALIDATE_INT,
299-
'section_state' => FILTER_DEFAULT,
300-
'section_class' => FILTER_DEFAULT,
301-
'message_ids' => FILTER_DEFAULT,
302-
'action_type' => FILTER_DEFAULT,
303-
'server_pw_id' => FILTER_DEFAULT,
304-
'message_list_since' => FILTER_DEFAULT,
299+
'section_state' => FILTER_UNSAFE_RAW,
300+
'section_class' => FILTER_UNSAFE_RAW,
301+
'message_ids' => FILTER_UNSAFE_RAW,
302+
'action_type' => FILTER_UNSAFE_RAW,
303+
'server_pw_id' => FILTER_UNSAFE_RAW,
304+
'message_list_since' => FILTER_UNSAFE_RAW,
305305
'no_password_save' => FILTER_VALIDATE_BOOLEAN,
306306
'start_page' => FILTER_SANITIZE_URL,
307-
'default_sort_order' => FILTER_DEFAULT,
307+
'default_sort_order' => FILTER_UNSAFE_RAW,
308308
'stay_logged_in' => FILTER_VALIDATE_BOOLEAN,
309309
'junk_per_source' => FILTER_VALIDATE_INT,
310-
'junk_since' => FILTER_DEFAULT,
310+
'junk_since' => FILTER_UNSAFE_RAW,
311+
'snoozed_per_source' => FILTER_VALIDATE_INT,
312+
'snoozed_since' => FILTER_UNSAFE_RAW,
311313
'trash_per_source' => FILTER_VALIDATE_INT,
312-
'trash_since' => FILTER_DEFAULT,
313-
'drafts_per_source' => FILTER_DEFAULT,
314-
'drafts_since' => FILTER_DEFAULT,
314+
'trash_since' => FILTER_UNSAFE_RAW,
315+
'drafts_per_source' => FILTER_UNSAFE_RAW,
316+
'drafts_since' => FILTER_UNSAFE_RAW,
315317
'warn_for_unsaved_changes' => FILTER_VALIDATE_BOOLEAN,
316-
'srv_setup_stepper_imap_server_id' => FILTER_DEFAULT,
317-
'srv_setup_stepper_smtp_server_id' => FILTER_DEFAULT,
318-
'srv_setup_stepper_profile_name' => FILTER_DEFAULT,
319-
'srv_setup_stepper_email' => FILTER_DEFAULT,
318+
'srv_setup_stepper_imap_server_id' => FILTER_UNSAFE_RAW,
319+
'srv_setup_stepper_smtp_server_id' => FILTER_UNSAFE_RAW,
320+
'srv_setup_stepper_profile_name' => FILTER_UNSAFE_RAW,
321+
'srv_setup_stepper_email' => FILTER_UNSAFE_RAW,
320322
'srv_setup_stepper_password' => FILTER_UNSAFE_RAW,
321-
'srv_setup_stepper_provider' => FILTER_DEFAULT,
323+
'srv_setup_stepper_provider' => FILTER_UNSAFE_RAW,
322324
'srv_setup_stepper_is_sender' => FILTER_VALIDATE_BOOLEAN,
323325
'srv_setup_stepper_is_receiver' => FILTER_VALIDATE_BOOLEAN,
324-
'srv_setup_stepper_smtp_address' => FILTER_DEFAULT,
325-
'srv_setup_stepper_smtp_port' => FILTER_DEFAULT,
326+
'srv_setup_stepper_smtp_address' => FILTER_UNSAFE_RAW,
327+
'srv_setup_stepper_smtp_port' => FILTER_UNSAFE_RAW,
326328
'srv_setup_stepper_smtp_tls' => FILTER_VALIDATE_BOOLEAN,
327-
'srv_setup_stepper_imap_address' => FILTER_DEFAULT,
328-
'srv_setup_stepper_imap_port' => FILTER_DEFAULT,
329+
'srv_setup_stepper_imap_address' => FILTER_UNSAFE_RAW,
330+
'srv_setup_stepper_imap_port' => FILTER_UNSAFE_RAW,
329331
'srv_setup_stepper_imap_tls' => FILTER_VALIDATE_BOOLEAN,
330332
'srv_setup_stepper_enable_sieve' => FILTER_VALIDATE_BOOLEAN,
331333
'srv_setup_stepper_create_profile' => FILTER_VALIDATE_BOOLEAN,
332334
'srv_setup_stepper_profile_is_default' => FILTER_VALIDATE_BOOLEAN,
333-
'srv_setup_stepper_profile_signature' => FILTER_DEFAULT,
334-
'srv_setup_stepper_profile_reply_to' => FILTER_DEFAULT,
335-
'srv_setup_stepper_imap_sieve_host' => FILTER_DEFAULT,
335+
'srv_setup_stepper_profile_signature' => FILTER_UNSAFE_RAW,
336+
'srv_setup_stepper_profile_reply_to' => FILTER_UNSAFE_RAW,
337+
'srv_setup_stepper_imap_sieve_host' => FILTER_UNSAFE_RAW,
338+
'srv_setup_stepper_imap_sieve_mode_tls' => FILTER_VALIDATE_BOOLEAN,
336339
'srv_setup_stepper_only_jmap' => FILTER_VALIDATE_BOOLEAN,
337340
'srv_setup_stepper_jmap_hide_from_c_page' => FILTER_VALIDATE_BOOLEAN,
338-
'srv_setup_stepper_jmap_address' => FILTER_DEFAULT,
339-
'srv_setup_stepper_imap_hide_from_c_page' => FILTER_VALIDATE_BOOLEAN
341+
'srv_setup_stepper_jmap_address' => FILTER_UNSAFE_RAW,
342+
'srv_setup_stepper_imap_hide_from_c_page' => FILTER_VALIDATE_BOOLEAN,
343+
'images_whitelist' => FILTER_UNSAFE_RAW,
344+
'update' => FILTER_VALIDATE_BOOLEAN,
345+
'enable_child_processes' => FILTER_VALIDATE_BOOLEAN,
340346
)
341347
);

modules/dynamic_login/setup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@
1313
'allowed_cookie' => array(),
1414
'allowed_server' => array(),
1515
'allowed_get' => array(),
16-
'allowed_post' => array('email_provider' => FILTER_DEFAULT)
16+
'allowed_post' => array('email_provider' => FILTER_UNSAFE_RAW)
1717
);

0 commit comments

Comments
 (0)