Skip to content

Commit f1da356

Browse files
committed
CM-53929 - Fix formatting
1 parent cca495b commit f1da356

File tree

10 files changed

+214
-196
lines changed

10 files changed

+214
-196
lines changed

cycode/cli/apps/report/sbom/path/path_command.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ def path_command(
3939
try:
4040
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
4141
documents = get_relevant_documents(
42-
progress_bar, SbomReportProgressBarSection.PREPARE_LOCAL_FILES, consts.SCA_SCAN_TYPE, (str(path),), is_cycodeignore_allowed=is_cycodeignore_allowed
42+
progress_bar,
43+
SbomReportProgressBarSection.PREPARE_LOCAL_FILES,
44+
consts.SCA_SCAN_TYPE,
45+
(str(path),),
46+
is_cycodeignore_allowed=is_cycodeignore_allowed,
4347
)
4448
# TODO(MarshalX): combine perform_pre_scan_documents_actions with get_relevant_document.
4549
# unhardcode usage of context in perform_pre_scan_documents_actions

cycode/cli/apps/scan/code_scanner.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
from cycode.cli.models import CliError, Document, LocalScanResult
2424
from cycode.cli.utils.progress_bar import ScanProgressBarSection
2525
from cycode.cli.utils.scan_batch import run_parallel_batched_scan
26-
from cycode.cli.utils.scan_utils import generate_unique_scan_id, is_cycodeignore_allowed_by_scan_config, set_issue_detected_by_scan_results
26+
from cycode.cli.utils.scan_utils import (
27+
generate_unique_scan_id,
28+
is_cycodeignore_allowed_by_scan_config,
29+
set_issue_detected_by_scan_results,
30+
)
2731
from cycode.cyclient.models import ZippedFileScanResult
2832
from cycode.logger import get_logger
2933

@@ -43,7 +47,13 @@ def scan_disk_files(ctx: typer.Context, paths: tuple[str, ...]) -> None:
4347

4448
try:
4549
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
46-
documents = get_relevant_documents(progress_bar, ScanProgressBarSection.PREPARE_LOCAL_FILES, scan_type, paths, is_cycodeignore_allowed=is_cycodeignore_allowed)
50+
documents = get_relevant_documents(
51+
progress_bar,
52+
ScanProgressBarSection.PREPARE_LOCAL_FILES,
53+
scan_type,
54+
paths,
55+
is_cycodeignore_allowed=is_cycodeignore_allowed,
56+
)
4757
add_sca_dependencies_tree_documents_if_needed(ctx, scan_type, documents)
4858
scan_documents(ctx, documents, get_scan_parameters(ctx, paths))
4959
except Exception as e:

cycode/cli/apps/scan/commit_range_scanner.py

Lines changed: 26 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,11 @@
4141
from cycode.cli.utils.git_proxy import git_proxy
4242
from cycode.cli.utils.path_utils import get_path_by_os
4343
from cycode.cli.utils.progress_bar import ScanProgressBarSection
44-
from cycode.cli.utils.scan_utils import generate_unique_scan_id, is_cycodeignore_allowed_by_scan_config, set_issue_detected_by_scan_results
44+
from cycode.cli.utils.scan_utils import (
45+
generate_unique_scan_id,
46+
is_cycodeignore_allowed_by_scan_config,
47+
set_issue_detected_by_scan_results,
48+
)
4549
from cycode.cyclient.models import ZippedFileScanResult
4650
from cycode.logger import get_logger
4751

@@ -189,9 +193,11 @@ def _scan_sca_commit_range(ctx: typer.Context, repo_path: str, commit_range: str
189193
)
190194
from_commit_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SCA_SCAN_TYPE, from_commit_documents)
191195
to_commit_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SCA_SCAN_TYPE, to_commit_documents)
192-
196+
193197
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
194-
from_commit_documents = filter_documents_with_cycodeignore(from_commit_documents, repo_path, is_cycodeignore_allowed)
198+
from_commit_documents = filter_documents_with_cycodeignore(
199+
from_commit_documents, repo_path, is_cycodeignore_allowed
200+
)
195201
to_commit_documents = filter_documents_with_cycodeignore(to_commit_documents, repo_path, is_cycodeignore_allowed)
196202

197203
perform_sca_pre_commit_range_scan_actions(
@@ -208,9 +214,11 @@ def _scan_secret_commit_range(
208214
diff_documents_to_scan = excluder.exclude_irrelevant_documents_to_scan(
209215
consts.SECRET_SCAN_TYPE, commit_diff_documents_to_scan
210216
)
211-
217+
212218
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
213-
diff_documents_to_scan = filter_documents_with_cycodeignore(diff_documents_to_scan, repo_path, is_cycodeignore_allowed)
219+
diff_documents_to_scan = filter_documents_with_cycodeignore(
220+
diff_documents_to_scan, repo_path, is_cycodeignore_allowed
221+
)
214222

215223
scan_documents(
216224
ctx, diff_documents_to_scan, get_scan_parameters(ctx, (repo_path,)), is_git_diff=True, is_commit_range=True
@@ -229,10 +237,10 @@ def _scan_sast_commit_range(ctx: typer.Context, repo_path: str, commit_range: st
229237
to_commit_rev,
230238
reverse_diff=False,
231239
)
232-
240+
233241
commit_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SAST_SCAN_TYPE, commit_documents)
234242
diff_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SAST_SCAN_TYPE, diff_documents)
235-
243+
236244
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
237245
commit_documents = filter_documents_with_cycodeignore(commit_documents, repo_path, is_cycodeignore_allowed)
238246
diff_documents = filter_documents_with_cycodeignore(diff_documents, repo_path, is_cycodeignore_allowed)
@@ -267,15 +275,17 @@ def _scan_sca_pre_commit(ctx: typer.Context, repo_path: str) -> None:
267275
progress_bar_section=ScanProgressBarSection.PREPARE_LOCAL_FILES,
268276
repo_path=repo_path,
269277
)
270-
278+
271279
git_head_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SCA_SCAN_TYPE, git_head_documents)
272280
pre_committed_documents = excluder.exclude_irrelevant_documents_to_scan(
273281
consts.SCA_SCAN_TYPE, pre_committed_documents
274282
)
275-
283+
276284
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
277285
git_head_documents = filter_documents_with_cycodeignore(git_head_documents, repo_path, is_cycodeignore_allowed)
278-
pre_committed_documents = filter_documents_with_cycodeignore(pre_committed_documents, repo_path, is_cycodeignore_allowed)
286+
pre_committed_documents = filter_documents_with_cycodeignore(
287+
pre_committed_documents, repo_path, is_cycodeignore_allowed
288+
)
279289

280290
perform_sca_pre_hook_range_scan_actions(repo_path, git_head_documents, pre_committed_documents)
281291

@@ -308,7 +318,7 @@ def _scan_secret_pre_commit(ctx: typer.Context, repo_path: str) -> None:
308318
)
309319

310320
documents_to_scan = excluder.exclude_irrelevant_documents_to_scan(consts.SECRET_SCAN_TYPE, documents_to_scan)
311-
321+
312322
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
313323
documents_to_scan = filter_documents_with_cycodeignore(documents_to_scan, repo_path, is_cycodeignore_allowed)
314324

@@ -323,14 +333,16 @@ def _scan_sast_pre_commit(ctx: typer.Context, repo_path: str, **_) -> None:
323333
progress_bar_section=ScanProgressBarSection.PREPARE_LOCAL_FILES,
324334
repo_path=repo_path,
325335
)
326-
336+
327337
pre_committed_documents = excluder.exclude_irrelevant_documents_to_scan(
328338
consts.SAST_SCAN_TYPE, pre_committed_documents
329339
)
330340
diff_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SAST_SCAN_TYPE, diff_documents)
331-
341+
332342
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
333-
pre_committed_documents = filter_documents_with_cycodeignore(pre_committed_documents, repo_path, is_cycodeignore_allowed)
343+
pre_committed_documents = filter_documents_with_cycodeignore(
344+
pre_committed_documents, repo_path, is_cycodeignore_allowed
345+
)
334346
diff_documents = filter_documents_with_cycodeignore(diff_documents, repo_path, is_cycodeignore_allowed)
335347

336348
_scan_commit_range_documents(ctx, pre_committed_documents, diff_documents, scan_parameters=scan_parameters)

cycode/cli/apps/scan/repository/repository_command.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def repository_command(
6161
)
6262

6363
documents_to_scan = excluder.exclude_irrelevant_documents_to_scan(scan_type, documents_to_scan)
64-
64+
6565
is_cycodeignore_allowed = is_cycodeignore_allowed_by_scan_config(ctx)
6666
documents_to_scan = filter_documents_with_cycodeignore(documents_to_scan, str(path), is_cycodeignore_allowed)
6767

cycode/cli/apps/scan/scan_command.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ def scan_command(
165165

166166
# Get remote URL from current working directory
167167
remote_url = _try_get_git_remote_url(os.getcwd())
168-
168+
169169
remote_scan_config = scan_client.get_scan_configuration_safe(scan_type, remote_url)
170170
if remote_scan_config:
171171
excluder.apply_scan_config(str(scan_type), remote_scan_config)
172-
172+
173173
ctx.obj['scan_config'] = remote_scan_config
174174

175175
if export_type and export_file:

cycode/cli/files_collector/documents_walk_ignore.py

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def _log_ignored_files(repo_path: str, dirpath: str, ignored_dirnames: list[str]
2929
"""Log ignored files for debugging (similar to walk_ignore function)."""
3030
rel_dirpath = '' if dirpath == repo_path else os.path.relpath(dirpath, repo_path)
3131
display_dir = rel_dirpath or '.'
32-
32+
3333
for is_dir, names in (
3434
(True, ignored_dirnames),
3535
(False, ignored_filenames),
@@ -44,14 +44,14 @@ def _log_ignored_files(repo_path: str, dirpath: str, ignored_dirnames: list[str]
4444
def _build_allowed_paths_set(ignore_filter_manager: IgnoreFilterManager, repo_path: str) -> set[str]:
4545
"""Build set of allowed file paths using walk_with_ignored."""
4646
allowed_paths = set()
47-
47+
4848
for dirpath, dirnames, filenames, ignored_dirnames, ignored_filenames in ignore_filter_manager.walk_with_ignored():
4949
_log_ignored_files(repo_path, dirpath, ignored_dirnames, ignored_filenames)
50-
50+
5151
for filename in filenames:
5252
file_path = os.path.join(dirpath, filename)
5353
allowed_paths.add(file_path)
54-
54+
5555
return allowed_paths
5656

5757

@@ -63,22 +63,20 @@ def _get_document_check_path(document: 'Document', repo_path: str) -> str:
6363
check_path = document.path
6464
else:
6565
check_path = os.path.join(repo_path, document.path)
66-
66+
6767
return os.path.normpath(check_path)
6868

6969

7070
def _filter_documents_by_allowed_paths(
71-
documents: list['Document'],
72-
allowed_paths: set[str],
73-
repo_path: str
71+
documents: list['Document'], allowed_paths: set[str], repo_path: str
7472
) -> list['Document']:
7573
"""Filter documents by checking if their paths are in the allowed set."""
7674
filtered_documents = []
77-
75+
7876
for document in documents:
7977
try:
8078
check_path = _get_document_check_path(document, repo_path)
81-
79+
8280
if check_path in allowed_paths:
8381
filtered_documents.append(document)
8482
else:
@@ -87,44 +85,42 @@ def _filter_documents_by_allowed_paths(
8785
except Exception as e:
8886
logger.debug('Error processing document %s: %s', document.path, e)
8987
filtered_documents.append(document)
90-
88+
9189
return filtered_documents
9290

9391

9492
def filter_documents_with_cycodeignore(
95-
documents: list['Document'],
96-
repo_path: str,
97-
is_cycodeignore_allowed: bool = True
93+
documents: list['Document'], repo_path: str, is_cycodeignore_allowed: bool = True
9894
) -> list['Document']:
9995
"""Filter documents based on .cycodeignore patterns.
100-
96+
10197
This function uses .cycodeignore file in the repository root to filter out
10298
documents whose paths match any of those patterns.
103-
99+
104100
Args:
105101
documents: List of Document objects to filter
106102
repo_path: Path to the repository root
107103
is_cycodeignore_allowed: Whether .cycodeignore filtering is allowed by scan configuration
108-
104+
109105
Returns:
110106
List of Document objects that don't match any .cycodeignore patterns
111107
"""
112108
if not is_cycodeignore_allowed:
113109
logger.debug('.cycodeignore filtering is not allowed by scan configuration')
114110
return documents
115-
111+
116112
cycodeignore_path = _get_cycodeignore_path(repo_path)
117-
113+
118114
if not os.path.exists(cycodeignore_path):
119115
return documents
120-
116+
121117
logger.info('Using %s for filtering documents', cycodeignore_path)
122-
118+
123119
ignore_filter_manager = _create_ignore_filter_manager(repo_path, cycodeignore_path)
124-
120+
125121
allowed_paths = _build_allowed_paths_set(ignore_filter_manager, repo_path)
126-
122+
127123
filtered_documents = _filter_documents_by_allowed_paths(documents, allowed_paths, repo_path)
128-
124+
129125
logger.debug('Filtered %d documents using .cycodeignore patterns', len(documents) - len(filtered_documents))
130126
return filtered_documents

cycode/cli/files_collector/path_documents.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,15 @@
1818

1919

2020
def _get_all_existing_files_in_directory(
21-
path: str,
22-
*,
23-
walk_with_ignore_patterns: bool = True,
24-
is_cycodeignore_allowed: bool = True
21+
path: str, *, walk_with_ignore_patterns: bool = True, is_cycodeignore_allowed: bool = True
2522
) -> list[str]:
2623
files: list[str] = []
2724

2825
if walk_with_ignore_patterns:
2926
walk_func = lambda p: walk_ignore(p, is_cycodeignore_allowed=is_cycodeignore_allowed)
3027
else:
3128
walk_func = os.walk
32-
29+
3330
for root, _, filenames in walk_func(path):
3431
for filename in filenames:
3532
files.append(os.path.join(root, filename))
@@ -51,12 +48,12 @@ def _get_relevant_files_in_path(path: str, *, is_cycodeignore_allowed: bool = Tr
5148

5249

5350
def _get_relevant_files(
54-
progress_bar: 'BaseProgressBar',
55-
progress_bar_section: 'ProgressBarSection',
56-
scan_type: str,
51+
progress_bar: 'BaseProgressBar',
52+
progress_bar_section: 'ProgressBarSection',
53+
scan_type: str,
5754
paths: tuple[str, ...],
5855
*,
59-
is_cycodeignore_allowed: bool = True
56+
is_cycodeignore_allowed: bool = True,
6057
) -> list[str]:
6158
all_files_to_scan = []
6259
for path in paths:
@@ -110,7 +107,9 @@ def get_relevant_documents(
110107
is_git_diff: bool = False,
111108
is_cycodeignore_allowed: bool = True,
112109
) -> list[Document]:
113-
relevant_files = _get_relevant_files(progress_bar, progress_bar_section, scan_type, paths, is_cycodeignore_allowed=is_cycodeignore_allowed)
110+
relevant_files = _get_relevant_files(
111+
progress_bar, progress_bar_section, scan_type, paths, is_cycodeignore_allowed=is_cycodeignore_allowed
112+
)
114113

115114
documents: list[Document] = []
116115
for file in relevant_files:

cycode/cli/files_collector/walk_ignore.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ def _walk_to_top(path: str) -> Iterable[str]:
2929
def _collect_top_level_ignore_files(path: str, *, is_cycodeignore_allowed: bool = True) -> list[str]:
3030
ignore_files = []
3131
top_paths = reversed(list(_walk_to_top(path))) # we must reverse it to make top levels more prioritized
32-
32+
3333
supported_files = set(_SUPPORTED_IGNORE_PATTERN_FILES)
3434
if is_cycodeignore_allowed:
3535
supported_files.add(consts.CYCODEIGNORE_FILENAME)
3636
logger.debug('.cycodeignore files included due to scan configuration')
37-
37+
3838
for dir_path in top_paths:
3939
for ignore_file in supported_files:
4040
ignore_file_path = os.path.join(dir_path, ignore_file)
@@ -44,7 +44,9 @@ def _collect_top_level_ignore_files(path: str, *, is_cycodeignore_allowed: bool
4444
return ignore_files
4545

4646

47-
def walk_ignore(path: str, *, is_cycodeignore_allowed: bool = True) -> Generator[tuple[str, list[str], list[str]], None, None]:
47+
def walk_ignore(
48+
path: str, *, is_cycodeignore_allowed: bool = True
49+
) -> Generator[tuple[str, list[str], list[str]], None, None]:
4850
ignore_file_paths = _collect_top_level_ignore_files(path, is_cycodeignore_allowed=is_cycodeignore_allowed)
4951
ignore_filter_manager = IgnoreFilterManager.build(
5052
path=path,
@@ -64,4 +66,4 @@ def walk_ignore(path: str, *, is_cycodeignore_allowed: bool = True) -> Generator
6466
full_path = os.path.join(full_path, '*')
6567
logger.debug('Ignoring match %s', full_path)
6668

67-
yield dirpath, dirnames, filenames
69+
yield dirpath, dirnames, filenames

cycode/cyclient/scan_client.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,15 +284,17 @@ def get_scan_configuration(self, scan_type: str, remote_url: Optional[str] = Non
284284
params = {}
285285
if remote_url:
286286
params['remote_url'] = remote_url
287-
287+
288288
response = self.scan_cycode_client.get(
289289
url_path=self.get_scan_configuration_path(scan_type),
290290
params=params,
291291
hide_response_content_log=self._hide_response_log,
292292
)
293293
return models.ScanConfigurationSchema().load(response.json())
294294

295-
def get_scan_configuration_safe(self, scan_type: str, remote_url: Optional[str] = None) -> Optional['models.ScanConfiguration']:
295+
def get_scan_configuration_safe(
296+
self, scan_type: str, remote_url: Optional[str] = None
297+
) -> Optional['models.ScanConfiguration']:
296298
try:
297299
return self.get_scan_configuration(scan_type, remote_url)
298300
except RequestHttpError as e:

0 commit comments

Comments
 (0)