match logic with git cli

Author: MarshalX

cycode/cli/apps/scan/commit_range_scanner.py

@@ -205,9 +205,13 @@ def _scan_sast_commit_range(ctx: typer.Context, repo_path: str, commit_range: st
     scan_parameters = get_scan_parameters(ctx, (repo_path,))
 
     from_commit_rev, to_commit_rev = parse_commit_range_sast(commit_range, repo_path)
-    # we are using from_commit_documents here because of flipped mess with R=True, differences in parsing commit ranges
-    commit_documents, _, diff_documents = get_commit_range_modified_documents(
-        ctx.obj['progress_bar'], ScanProgressBarSection.PREPARE_LOCAL_FILES, repo_path, from_commit_rev, to_commit_rev
+    _, commit_documents, diff_documents = get_commit_range_modified_documents(
+        ctx.obj['progress_bar'],
+        ScanProgressBarSection.PREPARE_LOCAL_FILES,
+        repo_path,
+        from_commit_rev,
+        to_commit_rev,
+        reverse_diff=False,
     )
     commit_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SAST_SCAN_TYPE, commit_documents)
     diff_documents = excluder.exclude_irrelevant_documents_to_scan(consts.SAST_SCAN_TYPE, diff_documents)

cycode/cli/files_collector/commit_range_documents.py

@@ -125,13 +125,14 @@ def get_commit_range_modified_documents(
     path: str,
     from_commit_rev: str,
     to_commit_rev: str,
+    reverse_diff: bool = True,
 ) -> tuple[list[Document], list[Document], list[Document]]:
     from_commit_documents = []
     to_commit_documents = []
     diff_documents = []
 
     repo = git_proxy.get_repo(path)
-    diff_index = repo.commit(from_commit_rev).diff(to_commit_rev, create_patch=True, R=True)
+    diff_index = repo.commit(from_commit_rev).diff(to_commit_rev, create_patch=True, R=reverse_diff)
 
     modified_files_diff = [
         diff for diff in diff_index if diff.change_type != consts.COMMIT_DIFF_DELETED_FILE_CHANGE_TYPE