Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_prettyPrintNumber is US-only? #245

Open
jd-bus opened this issue Jul 6, 2024 · 1 comment
Open

_prettyPrintNumber is US-only? #245

jd-bus opened this issue Jul 6, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jd-bus
Copy link

jd-bus commented Jul 6, 2024

Issue Summary

The implementation of ActiveCall _prettyPrintNumber does not use a proper international number formatter. Instead it seems to be hardcoded to assume that the number is USA format. This affects ActiveCall.toFormatted and ActiveCall.fromFormatted.

Steps to Reproduce

Try calling an international number like +52 55-2591-9530.

Expectation: toFormatted should return like: +52 55-2591-9530
Observed result: toFormatted returns: (525) 525-919530

@cybex-dev
Copy link
Owner

Good day @jd-bus

I apologize for the delay in response.

Thank you for reaching out, this is a great issue and thank you for bringing it to my attention. Originally, the focus was for the US market but I'll certainly expand it's use to support international phone numbers with E.164 support.

Expect this in the next update.

@cybex-dev cybex-dev self-assigned this Sep 3, 2024
@cybex-dev cybex-dev added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants