Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Call Direction in sendPhoneCallEvents description to fix customPa… #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Call Direction in sendPhoneCallEvents description to fix customPa… #233

wants to merge 1 commit into from

Conversation

agent515
Copy link
Contributor

@agent515 agent515 commented May 8, 2024 •
edited
Loading

…rams being null in Active Call on Answer.

Fixes #232

Call Direction is added to the Call Event log to satisfy tokens.length == 5 condition in parseCustomParams().

Map<String, dynamic>? parseCustomParams(List<String> tokens) {
  if (tokens.length != 5) return null;
  try {
    Map<String, dynamic> customValue = jsonDecode(tokens[4]);
    return customValue;
  } catch (error) {
    return null;
  }
}

@cybex-dev cybex-dev self-assigned this May 14, 2024
@cybex-dev
Copy link
Owner

Thank you for the PR - will review and merge this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cybex-dev cybex-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customParams field in Active Call is null on Answer event.
2 participants
@agent515 @cybex-dev