Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue: object interpolated incorrectly if a frame with the object keyframe is deleted #8951

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 16, 2025

Motivation and context

Issue comes from the fact that we get a list of deleted frames from different sources across the application.
This patch tries to fix that behaviour.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 93.42105% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.84%. Comparing base (8613254) to head (0ef5857).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8951      +/-   ##
===========================================
- Coverage    73.88%   73.84%   -0.04%     
===========================================
  Files          416      417       +1     
  Lines        44421    44586     +165     
  Branches      3996     4030      +34     
===========================================
+ Hits         32820    32926     +106     
- Misses       11601    11660      +59     
Components Coverage Δ
cvat-ui 78.30% <81.68%> (-0.12%) ⬇️
cvat-server 70.06% <ø> (ø)

cvat-core/src/frames.ts Show resolved Hide resolved
cvat-core/src/annotations-objects.ts Outdated Show resolved Hide resolved
cvat-core/src/annotations-objects.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants