Skip to content

Commit b0121d3

Browse files
Christoph Läubrichlaeubi
Christoph Läubrich
authored andcommitted
Embedd the cucumber expression jar to access package private methods
See cucumber/cucumber-expressions#51
1 parent c135d63 commit b0121d3

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

io.cucumber.eclipse.editor/.classpath

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<classpath>
3+
<classpathentry exported="true" kind="lib" path="META-INF/cucumber-expressions-18.0.1.jar"/>
34
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21">
45
<attributes>
56
<attribute name="module" value="true"/>

io.cucumber.eclipse.editor/META-INF/MANIFEST.MF

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ Bundle-Name: Cucumber Editor
44
Bundle-SymbolicName: io.cucumber.eclipse.editor;singleton:=true
55
Bundle-Version: 3.0.0.qualifier
66
Bundle-Activator: io.cucumber.eclipse.editor.Activator
7+
Bundle-ClassPath: META-INF/cucumber-expressions-18.0.1.jar,
8+
.
79
Require-Bundle: org.eclipse.ui;bundle-version="3.5.0",
810
org.eclipse.core.runtime;bundle-version="3.5.0",
911
org.eclipse.ui.editors;bundle-version="3.5.0",
@@ -33,8 +35,7 @@ Require-Bundle: org.eclipse.ui;bundle-version="3.5.0",
3335
org.eclipse.ui.workbench.texteditor,
3436
org.apache.commons.commons-text;bundle-version="1.10.0",
3537
io.cucumber.tag-expressions,
36-
org.eclipse.unittest.ui;bundle-version="1.0.0",
37-
io.cucumber.cucumber-expressions;bundle-version="18.0.1"
38+
org.eclipse.unittest.ui;bundle-version="1.0.0"
3839
Bundle-RequiredExecutionEnvironment: JavaSE-21
3940
Automatic-Module-Name: io.cucumber.eclipse.editor
4041
Bundle-ActivationPolicy: lazy
Binary file not shown.

io.cucumber.eclipse.editor/build.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ output.. = bin/
33
bin.includes = .,\
44
plugin.xml,\
55
icons/,\
6-
META-INF/,\
76
.options,\
8-
OSGI-INF/
7+
OSGI-INF/,\
8+
META-INF/

io.cucumber.eclipse.editor/src/io/cucumber/cucumberexpressions/CucumberExpressionParserSupport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*
2424
*/
2525
//TODO see bug Bug 570519 currently we must always supply the full text as the default value
26-
//TODO use public API (if available) for Cucumberparser + GroupPrser
26+
//TODO the AST is package protected API because of this we need to embedd the jar instead of consume it directly see https://github.com/cucumber/cucumber-expressions/issues/51
2727
public class CucumberExpressionParserSupport {
2828

2929
private static final Pattern BEGIN_ANCHOR = Pattern.compile("^\\^.*");

0 commit comments

Comments
 (0)