csfilter: abstract out precise numbers for IDENTIFIER_TYPO

Author: kdudka

csfilter.cc

@@ -110,6 +110,9 @@ struct MsgFilter::Private {
 
         // artificial field names of anonymous unions that Coverity produces
         addMsgFilter("", "__C[0-9]+");
+
+        // used by IDENTIFIER_TYPO (but applies generally)
+        addMsgFilter("", "at least [0-9][0-9]* times.$");
     }
 };
 

tests/CMakeLists.txt

@@ -175,3 +175,4 @@ test_csdiff(diff-misc                               02)
 test_csdiff(diff-misc                               03)
 test_csdiff(diff-misc                               04)
 test_csdiff(diff-misc                               05)
+test_csdiff(diff-misc                               06)

tests/diff-misc/06-add-z.err

@@ -0,0 +1,15 @@
+Error: IDENTIFIER_TYPO:
+anaconda-21.48.22.90/pyanaconda/ui/gui/spokes/source.py:1388: identifier_typo: Using "mirorlist" appears to be a typo:
+* Identifier "mirorlist" is only known to be referenced here, or in copies of this code.
+* Identifier "mirrorlist" is referenced elsewhere at least 27 times.
+anaconda-21.48.22.90/pyanaconda/packaging/__init__.py:1046: identifier_use: Example 1: Using identifier "mirrorlist".
+anaconda-21.48.22.90/pyanaconda/packaging/yumpayload.py:732: identifier_use: Example 2: Using identifier "mirrorlist".
+anaconda-21.48.22.90/pyanaconda/packaging/yumpayload.py:879: identifier_use: Example 3: Using identifier "mirrorlist".
+anaconda-21.48.22.90/pyanaconda/packaging/yumpayload.py:726: identifier_use: Example 4: Using identifier "mirrorlist".
+anaconda-21.48.22.90/pyanaconda/packaging/yumpayload.py:335: identifier_use: Example 5: Using identifier "mirrorlist" (2 total uses in this function).
+anaconda-21.48.22.90/pyanaconda/ui/gui/spokes/source.py:1388: remediation: Should identifier "mirorlist" be replaced by "mirrorlist"?
+# 1386|           url = self._repoUrlEntry.get_text().strip()
+# 1387|           if self._repoMirrorlistCheckbox.get_active():
+# 1388|->             repo.mirorlist = proto + url
+# 1389|           else:
+# 1390|               repo.baseurl = proto + url

tests/diff-misc/06-add.err

@@ -0,0 +1,15 @@
+Error: IDENTIFIER_TYPO:
+anaconda-21.48.22.56/pyanaconda/ui/gui/spokes/source.py:1345: identifier_typo: Using "mirorlist" appears to be a typo:
+* Identifier "mirorlist" is only known to be referenced here, or in copies of this code.
+* Identifier "mirrorlist" is referenced elsewhere at least 26 times.
+anaconda-21.48.22.56/pyanaconda/packaging/__init__.py:956: identifier_use: Example 1: Using identifier "mirrorlist".
+anaconda-21.48.22.56/pyanaconda/packaging/yumpayload.py:719: identifier_use: Example 2: Using identifier "mirrorlist".
+anaconda-21.48.22.56/pyanaconda/packaging/yumpayload.py:866: identifier_use: Example 3: Using identifier "mirrorlist".
+anaconda-21.48.22.56/pyanaconda/packaging/yumpayload.py:713: identifier_use: Example 4: Using identifier "mirrorlist".
+anaconda-21.48.22.56/pyanaconda/packaging/yumpayload.py:334: identifier_use: Example 5: Using identifier "mirrorlist" (2 total uses in this function).
+anaconda-21.48.22.56/pyanaconda/ui/gui/spokes/source.py:1345: remediation: Should identifier "mirorlist" be replaced by "mirrorlist"?
+# 1343|           url = self._repoUrlEntry.get_text().strip()
+# 1344|           if self._repoMirrorlistCheckbox.get_active():
+# 1345|->             repo.mirorlist = proto + url
+# 1346|           else:
+# 1347|               repo.baseurl = proto + url