csparser: add double_lock as key event for LOCK

Author: kdudka

csparser.cc

@@ -239,6 +239,7 @@ KeyEventDigger::KeyEventDigger():
     d->hMap["FORWARD_NULL"]         .insert("dereference");
     d->hMap["FORWARD_NULL"]         .insert("var_deref_op");
     d->hMap["FORWARD_NULL"]         .insert("var_deref_model");
+    d->hMap["LOCK"]                 .insert("double_lock");
     d->hMap["LOCK"]                 .insert("double_unlock");
     d->hMap["NESTING_INDENT_MISMATCH"].insert("dangling_else");
     d->hMap["NESTING_INDENT_MISMATCH"].insert("multi_stmt_macro");

tests/csgrep/44-csparser-new-key-evts-stdin.txt

@@ -136,3 +136,39 @@ Error: LOCK (CWE-667):
 389-ds-base-1.3.8.4/ldap/servers/slapd/slapi2nspr.c:253:9: unlock: "pthread_rwlock_unlock" unlocks "rwlock".
 389-ds-base-1.3.8.4/ldap/servers/plugins/replication/repl5_ruv.c:1428: double_unlock: "slapi_rwlock_unlock" unlocks "ruv->lock" while it is unlocked.
 389-ds-base-1.3.8.4/ldap/servers/slapd/slapi2nspr.c:253:9: unlock: "pthread_rwlock_unlock" unlocks "rwlock".
+
+Error: LOCK (CWE-667):
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:1209: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:1221: double_lock: "internal_ns_job_rearm" locks "job->monitor" while it is locked.
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:253:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:264:9: lock: "event_q_notify" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:522:9: lock: "update_event" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:425:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:431:9: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:432:9: lock: "internal_ns_job_done" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:217:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:242:5: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:243:5: destroy: "pthread_mutex_destroy" destroys "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:432:9: destroy: "internal_ns_job_done" destroys "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:217:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:242:5: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:243:5: destroy: "pthread_mutex_destroy" destroys "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:522:9: unlock: "update_event" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:425:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:440:9: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:264:9: unlock: "event_q_notify" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:522:9: lock: "update_event" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:425:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:431:9: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:432:9: lock: "internal_ns_job_done" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:217:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:242:5: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:243:5: destroy: "pthread_mutex_destroy" destroys "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:432:9: destroy: "internal_ns_job_done" destroys "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:217:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:242:5: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:243:5: destroy: "pthread_mutex_destroy" destroys "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:522:9: unlock: "update_event" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:425:5: lock: "pthread_mutex_lock" locks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:440:9: unlock: "pthread_mutex_unlock" unlocks "job->monitor".
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:270:5: unlock: "pthread_mutex_unlock" unlocks "job->monitor".

tests/csgrep/44-csparser-new-key-evts-stdout.txt

@@ -60,3 +60,6 @@ bind-9.11.3/lib/isc-pkcs11/mem.c:1608: incorrect_free: "mem_put" frees incorrect
 
 Error: LOCK (CWE-667):
 389-ds-base-1.3.8.4/ldap/servers/plugins/replication/repl5_ruv.c:1428: double_unlock: "slapi_rwlock_unlock" unlocks "ruv->lock" while it is unlocked.
+
+Error: LOCK (CWE-667):
+389-ds-base-1.3.8.4/src/nunc-stans/ns/ns_thrpool.c:1221: double_lock: "internal_ns_job_rearm" locks "job->monitor" while it is locked.