New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve focused elements styling #14

Open

moeenio opened this issue May 24, 2020 · 8 comments

Labels

enhancement good first issue

Member

moeenio commented May 24, 2020

it's not obvious when the "privacy banner"'s content is focused.
the "read more" buttons don't have focused styling

moeenio added enhancement good first issue labels

ghost commented May 24, 2020 •

edited by ghost

Loading

What is privacy banner ?

Member Author

moeenio commented May 24, 2020 •

edited

Loading

The "privacy information" pop-up

ghost commented May 24, 2020

Oh yeah

ghost commented Mar 9, 2021

I maybe a 2px purple outline?

Member Author

moeenio commented Mar 9, 2021

Rather a box-shadow with spread I think

ghost commented Mar 10, 2021

colored or not?

Member Author

moeenio commented Mar 10, 2021

Yes colored

Member Author

moeenio commented Mar 10, 2021

I'm thinking about something like github does :
https://github.com/primer/css/blob/d0c569c53e0f5a0564d197e4c2358ac2a01de5f3/src/support/variables/misc.scss#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment