Fix: manager no longer install path dependencies

PathResolver returns the installed spec from the local path (where
the source code is installed) because it links the `src` folder and
thus can't access `shard.yml` from its libs folder.

Yet PathResolver always returned something for the installed spec,
and thus the install and update commands thought it was already
installed, which was wrong.

Author: ysbaddaden

src/package.cr

@@ -32,10 +32,14 @@ module Shards
     end
 
     def installed?(loose = false)
-      if loose
-        matching_versions.includes?(resolver.spec(:installed).version)
+      if spec = resolver.installed_spec
+        if loose
+          matching_versions.includes?(spec.version)
+        else
+          version == spec.version
+        end
       else
-        version == resolver.spec(:installed).version
+        false
       end
     end
 

src/resolvers/path.cr

@@ -1,5 +1,5 @@
 require "./resolver"
-require "../core_ext/file"
+#require "../core_ext/file"
 
 module Shards
   class PathResolver < Resolver
@@ -13,13 +13,17 @@ module Shards
       end
     end
 
-    def spec(version = nil)
-      if version == :installed
-        path = File.join(local_path, SPEC_FILENAME)
-        return Spec.from_file(path) if File.exists?(path)
-      end
+    def installed_spec
+      return unless installed?
+
+      path = File.join(local_path, SPEC_FILENAME)
+      return Spec.from_file(path) if File.exists?(path)
+
+      Spec.from_yaml("name: #{dependency.name}\n")
+    end
 
-      super
+    def installed?
+      File.symlink?(install_path)
     end
 
     def available_versions

src/resolvers/resolver.cr

@@ -13,20 +13,20 @@ module Shards
     end
 
     def spec(version = nil)
-      if version == :installed
-        path = File.join(install_path, SPEC_FILENAME)
-        if File.exists?(path)
-          Spec.from_file(path)
-        else
-          Spec.from_yaml("name: #{dependency.name}\n")
-        end
-      else
-        Spec.from_yaml(read_spec(version))
-      end
+      Spec.from_yaml(read_spec(version))
+    end
+
+    def installed_spec
+      return unless installed?
+
+      path = File.join(install_path, SPEC_FILENAME)
+      return Spec.from_file(path) if File.exists?(path)
+
+      Spec.from_yaml("name: #{dependency.name}\n")
     end
 
-    def installed?(version)
-      spec(:installed).version == version
+    def installed?
+      File.exists?(install_path)
     end
 
     abstract def read_spec(version = nil)

test/git_resolver_test.cr

@@ -40,11 +40,11 @@ module Shards
       library.install("0.1.2")
       assert File.exists?(install_path("library", "library.cr"))
       assert File.exists?(install_path("library", "shard.yml"))
-      assert_equal "0.1.2", library.spec(:installed).version
+      assert_equal "0.1.2", library.installed_spec.not_nil!.version
       #assert File.exists?(install_path("library", "LICENSE"))
 
       library.install
-      assert_equal "0.2.0", library.spec(:installed).version
+      assert_equal "0.2.0", library.installed_spec.not_nil!.version
 
       legacy.install
       assert File.exists?(install_path("legacy", "legacy.cr"))
@@ -53,7 +53,7 @@ module Shards
       legacy.install("1.0.0")
       assert File.exists?(install_path("legacy", "legacy.cr"))
       assert File.exists?(install_path("legacy", "shard.yml"))
-      assert_equal "1.0.0", legacy.spec(:installed).version
+      assert_equal "1.0.0", legacy.installed_spec.not_nil!.version
 
       empty.install # HEAD
       assert File.exists?(install_path("empty", "empty.cr"))

test/path_resolver_test.cr

@@ -22,14 +22,14 @@ module Shards
         library.install
         assert File.exists?(install_path("library", "library.cr"))
         refute File.exists?(install_path("library", "shard.yml"))
-        assert_equal "1.2.3", library.spec(:installed).version
+        assert_equal "1.2.3", library.installed_spec.not_nil!.version
       end
 
       resolver("legacy").tap do |legacy|
         legacy.install
         assert File.exists?(install_path("legacy", "legacy.cr"))
         refute File.exists?(install_path("legacy", "shard.yml"))
-        assert_empty legacy.spec(:installed).version
+        assert_empty legacy.installed_spec.not_nil!.version
       end
     end