Skip to content

Move diagnostics reporting to annotate_snippets #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
W95Psp opened this issue Jun 27, 2024 · 1 comment · Fixed by #743
Closed

Move diagnostics reporting to annotate_snippets #739

W95Psp opened this issue Jun 27, 2024 · 1 comment · Fixed by #743
Labels
frontend Issue in the Rust to JSON translation

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Jun 27, 2024 •
edited
Loading

Since #735 Rustc doesn't allow us to report diagnostics with custom error codes any more.
This was needed for #277 anyway, and decoupling rustc sessions and error reporting will help in general with the design of the CLI.
@W95Psp W95Psp added the frontend Issue in the Rust to JSON translation label Jun 27, 2024
This was referenced Jun 27, 2024
Merged
Merged
@W95Psp
Copy link
Collaborator Author

W95Psp commented Jul 1, 2024

Miette was not the best candidate, since it's output format is very different from the one used in Rustc.
Also, Rustc exposes its own reporting crate, annotate_snippets, so let's use that instead.

@W95Psp W95Psp changed the title Move diagnostics reporting to miette Move diagnostics reporting to annotate_snippets Jul 1, 2024
@github-project-automation github-project-automation bot moved this to Done in hax Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Issue in the Rust to JSON translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor of the frontend cryspen/hax
1 participant
@W95Psp