Replace identifier() method by mere name() method

Author: infeo

src/main/java/org/cryptomator/cryptofs/health/api/HealthCheck.java

@@ -23,10 +23,11 @@ static Collection<HealthCheck> allChecks() {
 	}
 
 	/**
-	 * @return A unique name for this check (that might be used as a translation key)
+	 * @return A human readable name for this check
 	 */
-	default String identifier() {
-		return getClass().getCanonicalName();
+	default String name() {
+		var canonicalName = getClass().getCanonicalName();
+		return canonicalName.substring(canonicalName.lastIndexOf('.')+1);
 	}
 
 	/**
@@ -61,7 +62,7 @@ default Stream<DiagnosticResult> check(Path pathToVault, VaultConfig config, Mas
 			try {
 				check(pathToVault, config, masterkey, cryptor, resultSpliterator);
 			} catch (TransferSpliterator.TransferClosedException e) {
-				LoggerFactory.getLogger(HealthCheck.class).debug("{} cancelled.", identifier());
+				LoggerFactory.getLogger(HealthCheck.class).debug("{} cancelled.", name());
 			} finally {
 				resultSpliterator.close();
 			}

src/main/java/org/cryptomator/cryptofs/health/dirid/DirIdCheck.java

@@ -30,6 +30,12 @@ public class DirIdCheck implements HealthCheck {
 
 	private static final Logger LOG = LoggerFactory.getLogger(DirIdCheck.class);
 	private static final int MAX_TRAVERSAL_DEPTH = 4; // d/2/30/Fo0==.c9r/dir.c9r
+	private static final String CHECK_NAME = "Directory Check";
+
+	@Override
+	public String name() {
+		return CHECK_NAME;
+	}
 
 	@Override
 	public void check(Path pathToVault, VaultConfig config, Masterkey masterkey, Cryptor cryptor, Consumer<DiagnosticResult> resultCollector) {

src/test/java/org/cryptomator/cryptofs/health/api/HealthCheckIntegrationTest.java

@@ -42,7 +42,7 @@ public static void main(String[] args) throws IOException, NoSuchAlgorithmExcept
 				var cryptor = CryptorProvider.forScheme(verifiedCfg.getCipherCombo()).provide(masterkey, SecureRandom.getInstanceStrong());
 				var executor = Executors.newSingleThreadExecutor();
 				HealthCheck.allChecks().forEach(check -> {
-					System.out.println("Running " + check.identifier());
+					System.out.println("Running " + check.name());
 					var results = check.check(p, verifiedCfg, masterkey, cryptor, executor);
 					results.forEach(System.out::println);
 				});