Fix search and settings (#736)

* fix search editor error cannot be entered on PC

* (settings) Fix warning text display delay when selecting exchange

* display a warning when the exchange settings have been changed automatically because the rate is not getted

* update outdated version on workflow

Author: vufon

.github/workflows/go.yml

@@ -6,7 +6,7 @@ jobs:
     runs-on: ubuntu-20.04
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v1
+        uses: actions/checkout@v3
 
       - name: Set up Go 1.21
         uses: actions/setup-go@v3
@@ -24,7 +24,7 @@ jobs:
           cp "./libwallet/instantswap/instant_example.json" "./libwallet/instantswap/instant.json"
 
       - name: Cache (dependencies)
-        uses: actions/cache@v1
+        uses: actions/cache@v4
         id: cache
         with:
           path: ~/go/pkg/mod

libwallet/ext/rate_source.go

@@ -125,36 +125,44 @@ type RateSource interface {
 	ToggleSource(newSource string) error
 	AddRateListener(listener *RateListener, uniqueIdentifier string) error
 	RemoveRateListener(uniqueIdentifier string)
+	AddWarningMsgListener(listener *WarningMsgListener, uniqueIdentifier string) error
+	RemoveWarningMsgListener(uniqueIdentifier string)
 	IsRateListenerExist(uniqueIdentifier string) bool
+	IsWarningMsgListenerExist(uniqueIdentifier string) bool
 }
 
 // RateListener listens for new tickers and rate source change notifications.
 type RateListener struct {
 	OnRateUpdated func()
 }
 
+// WarningMsgListener listens for new fetch exchange rate settings warning message.
+type WarningMsgListener struct {
+	OnWarningMsgUpdated func(string)
+}
+
 type tickerFunc func(market values.Market) (*Ticker, error)
 
 // CommonRateSource is an external rate source for fiat and crypto-currency
 // rates. These rates are estimates and maybe be affected by server latency and
 // should not be used for actual buy or sell orders except to display reasonable
 // estimates. CommonRateSource is embedded in all of the rate sources supported.
 type CommonRateSource struct {
-	ctx           context.Context
-	source        string
-	disabled      bool
-	mtx           sync.RWMutex
-	tickers       map[values.Market]*Ticker
-	refreshing    bool
-	cond          *sync.Cond
-	getTicker     tickerFunc
-	sourceChanged chan *struct{}
-	lastUpdate    time.Time
-
+	ctx                       context.Context
+	source                    string
+	disabled                  bool
+	mtx                       sync.RWMutex
+	tickers                   map[values.Market]*Ticker
+	refreshing                bool
+	cond                      *sync.Cond
+	getTicker                 tickerFunc
+	sourceChanged             chan *struct{}
+	lastUpdate                time.Time
 	disableConversionExchange func()
 
 	notificationListenersMu sync.RWMutex
 	ratesListeners          map[string]*RateListener
+	warningMsgListeners     map[string]*WarningMsgListener
 }
 
 // Used to initialize a rate source.
@@ -170,6 +178,7 @@ func NewCommonRateSource(ctx context.Context, source string, disableConversionEx
 		sourceChanged:             make(chan *struct{}),
 		disableConversionExchange: disableConversionExchange,
 		ratesListeners:            make(map[string]*RateListener),
+		warningMsgListeners:       make(map[string]*WarningMsgListener),
 	}
 	s.getTicker = s.sourceGetTickerFunc(source)
 	s.cond = sync.NewCond(&s.mtx)
@@ -220,6 +229,17 @@ func (cs *CommonRateSource) isDisabled() bool {
 	return cs.disabled
 }
 
+func (cs *CommonRateSource) AddWarningMsgListener(listener *WarningMsgListener, uniqueIdentifier string) error {
+	if _, ok := cs.warningMsgListeners[uniqueIdentifier]; ok {
+		return errors.New(utils.ErrListenerAlreadyExist)
+	}
+
+	cs.notificationListenersMu.Lock()
+	defer cs.notificationListenersMu.Unlock()
+	cs.warningMsgListeners[uniqueIdentifier] = listener
+	return nil
+}
+
 func (cs *CommonRateSource) AddRateListener(listener *RateListener, uniqueIdentifier string) error {
 	if _, ok := cs.ratesListeners[uniqueIdentifier]; ok {
 		return errors.New(utils.ErrListenerAlreadyExist)
@@ -236,6 +256,17 @@ func (cs *CommonRateSource) IsRateListenerExist(uniqueIdentifier string) bool {
 	return ok
 }
 
+func (cs *CommonRateSource) IsWarningMsgListenerExist(uniqueIdentifier string) bool {
+	_, ok := cs.warningMsgListeners[uniqueIdentifier]
+	return ok
+}
+
+func (cs *CommonRateSource) RemoveWarningMsgListener(uniqueIdentifier string) {
+	cs.notificationListenersMu.Lock()
+	defer cs.notificationListenersMu.Unlock()
+	delete(cs.warningMsgListeners, uniqueIdentifier)
+}
+
 func (cs *CommonRateSource) RemoveRateListener(uniqueIdentifier string) {
 	cs.notificationListenersMu.Lock()
 	defer cs.notificationListenersMu.Unlock()
@@ -250,6 +281,14 @@ func (cs *CommonRateSource) pushlishRateUpdated() {
 	}
 }
 
+func (cs *CommonRateSource) pushlishWarningMsgUpdated(warningMsg string) {
+	for _, listener := range cs.warningMsgListeners {
+		if listener.OnWarningMsgUpdated != nil {
+			listener.OnWarningMsgUpdated(warningMsg)
+		}
+	}
+}
+
 // ToggleSource changes the rate source to newSource. This method takes some
 // time to refresh the rates and should be executed a a goroutine.
 func (cs *CommonRateSource) ToggleSource(newSource string) error {
@@ -413,21 +452,24 @@ func (cs *CommonRateSource) retryGetTicker(market values.Market) (*Ticker, error
 	}
 	// fetch ticker from available exchanges
 	log.Infof("fetching from other exchanges")
+	invalidSource := cs.source
 	for _, source := range sources {
-		if source == cs.source {
+		if source == invalidSource {
 			continue
 		}
 		getTickerFn := cs.sourceGetTickerFunc(source)
 		select {
 		case <-cs.ctx.Done():
 			log.Errorf("fetching ticker canceled: %v", cs.ctx.Err())
+			cs.source = invalidSource
 			return nil, cs.ctx.Err()
 		default:
 			log.Infof("fetching %s rate from %v", market, source)
+			cs.source = source
 			newTicker, err = getTickerFn(market)
 			if err == nil {
+				cs.pushlishWarningMsgUpdated(fmt.Sprintf(values.String(values.StrFetchRateWarningContent), invalidSource, source))
 				log.Infof("%s is chosen", source)
-				cs.source = source
 				return newTicker, nil
 			}
 		}

ui/modal/info_modal.go

@@ -85,6 +85,14 @@ func NewErrorModal(l *load.Load, title string, clicked ClickFunc) *InfoModal {
 	return md
 }
 
+// NewWarningModal returns the default warning modal UI component.
+func NewWarningModal(l *load.Load, title string, clicked ClickFunc) *InfoModal {
+	icon := l.Theme.Icons.OrangeAlert
+	md := newModal(l, title, icon, clicked)
+	md.SetContentAlignment(layout.Center, layout.Center, layout.Center)
+	return md
+}
+
 // DefaultClickFunc returns the default click function satisfying the positive
 // btn click function.
 func DefaultClickFunc() ClickFunc {

ui/page/settings/app_settings_page.go

@@ -16,6 +16,7 @@ import (
 
 	"github.com/crypto-power/cryptopower/app"
 	sharedW "github.com/crypto-power/cryptopower/libwallet/assets/wallet"
+	"github.com/crypto-power/cryptopower/libwallet/ext"
 	libutils "github.com/crypto-power/cryptopower/libwallet/utils"
 	"github.com/crypto-power/cryptopower/logger"
 	"github.com/crypto-power/cryptopower/ui/cryptomaterial"
@@ -131,6 +132,35 @@ func NewAppSettingsPage(l *load.Load) *AppSettingsPage {
 // Part of the load.Page interface.
 func (pg *AppSettingsPage) OnNavigatedTo() {
 	pg.updateSettingOptions()
+	pg.ListenForRateWarningMsgChange()
+}
+
+func (pg *AppSettingsPage) ListenForRateWarningMsgChange() {
+	// add rate listener
+	warningMsgListener := &ext.WarningMsgListener{
+		OnWarningMsgUpdated: func(warning string) {
+			if warning != "" {
+				go pg.showAutoChangeRateSourceNotice(warning)
+			}
+		},
+	}
+	if !pg.AssetsManager.RateSource.IsWarningMsgListenerExist(AppSettingsPageID) {
+		if err := pg.AssetsManager.RateSource.AddWarningMsgListener(warningMsgListener, AppSettingsPageID); err != nil {
+			log.Error("Can't listen warning message.")
+		}
+	}
+}
+
+// Show warning about fetch exchange rate setting
+// when exchange is changed due to unable to fetch rate
+func (pg *AppSettingsPage) showAutoChangeRateSourceNotice(warnMsg string) {
+	lowStorageModal := modal.NewWarningModal(pg.Load, values.String(values.StrFetchRateWarningTitle),
+		func(_ bool, _ *modal.InfoModal) bool {
+			return true
+		}).
+		Body(warnMsg).
+		SetPositiveButtonText(values.String(values.StrOK))
+	pg.ParentWindow().ShowModal(lowStorageModal)
 }
 
 // Layout draws the page UI components into the provided C
@@ -847,6 +877,8 @@ func (pg *AppSettingsPage) updatePrivacySettings() {
 // Part of the load.Page interface.
 func (pg *AppSettingsPage) OnNavigatedFrom() {
 	utils.ZeroBytes(pg.dexSeed)
+	// remove fetch exchange rate warning msg listener
+	pg.AssetsManager.RateSource.RemoveWarningMsgListener(AppSettingsPageID)
 }
 
 func (pg *AppSettingsPage) setInitialSwitchStatus(switchComponent *cryptomaterial.Switch, isChecked bool) {

ui/page/transaction/transactions_page.go

@@ -684,17 +684,10 @@ func (pg *TransactionsPage) HandleUserInteractions(gtx C) {
 		pg.scroll.FetchScrollData(false, pg.ParentWindow(), true)
 	}
 
-	for {
-		event, ok := pg.searchEditor.Editor.Update(gtx)
-		if !ok {
-			break
-		}
-
-		if gtx.Source.Focused(pg.searchEditor.Editor) {
-			switch event.(type) {
-			case widget.ChangeEvent:
-				pg.scroll.FetchScrollData(false, pg.ParentWindow(), true)
-			}
+	// When focus on search editor
+	if gtx.Source.Focused(pg.searchEditor.Editor) {
+		if pg.searchEditor.Changed() {
+			pg.scroll.FetchScrollData(false, pg.ParentWindow(), true)
 		}
 	}
 }

ui/preference/list_preference.go

@@ -194,6 +194,8 @@ func (lp *ListPreferenceModal) Handle(gtx C) {
 		lp.Dismiss()
 	}
 
+	lp.optionsRadioGroup.Update(gtx)
+
 	if lp.btnCancel.Button.Clicked(gtx) {
 		lp.Modal.Dismiss()
 	}

ui/values/localizable/en.go

@@ -954,6 +954,8 @@ const EN = `
 "rateBinanceWarning" = "*Some countries are restricted on Binance and may not be able to fetch rate."
 "rateBittrexWarning" = "*Some countries are restricted on Bittrex and may not be able to fetch rate."
 "rateKucoinWarning" = "*Some countries are restricted on Kucoin and may not be able to fetch rate."
+"fetchRateWarningTitle" = "Settings Warning"
+"fetchRateWarningContent" = "Can't get rate ticker from %s. The settings have been changed to %s."
 "restrictDetail" = "Restriction Detail"
 "rateUnavailable" = "The rate unavailable this time, please reset it later in settings."
 "privacy" = "Privacy"

ui/values/strings.go

@@ -1065,6 +1065,8 @@ const (
 	StrRateBinanceWarning                    = "rateBinanceWarning"
 	StrRateBittrexWarning                    = "rateBittrexWarning"
 	StrRateKucoinWarning                     = "rateKucoinWarning"
+	StrFetchRateWarningTitle                 = "fetchRateWarningTitle"
+	StrFetchRateWarningContent               = "fetchRateWarningContent"
 	StrRestrictedDetail                      = "restrictDetail"
 	StrRateUnavailable                       = "rateUnavailable"
 	StrPrivacy                               = "privacy"