Problem: unnecessary length check in logsFromTxResponse (#580)

mmsqe · web-flow · commit 434f46d2a46c · 2025-04-09T02:27:16.000Z
diff --git a/x/evm/types/utils.go b/x/evm/types/utils.go
@@ -76,10 +76,6 @@ func DecodeTxResponses(in []byte) ([]*MsgEthereumTxResponse, error) {
 }
 
 func logsFromTxResponse(dst []*ethtypes.Log, rsp *MsgEthereumTxResponse, blockNumber uint64) []*ethtypes.Log {
-	if len(rsp.Logs) == 0 {
-		return dst
-	}
-
 	if dst == nil {
 		dst = make([]*ethtypes.Log, 0, len(rsp.Logs))
 	}

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,6 @@ func DecodeTxResponses(in []byte) ([]*MsgEthereumTxResponse, error) {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`func logsFromTxResponse(dst []ethtypes.Log, rsp MsgEthereumTxResponse, blockNumber uint64) []*ethtypes.Log {`
`79`		`- if len(rsp.Logs) == 0 {`
`80`		`- return dst`
`81`		`- }`
`82`		`-`
`83`	`79`	`if dst == nil {`
`84`	`80`	`dst = make([]*ethtypes.Log, 0, len(rsp.Logs))`
`85`	`81`	`}`