Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] cannot assign sort tags to some channel rewards #3031

Open
1 task done
dennisrijsdijk opened this issue Mar 1, 2025 · 0 comments
Open
1 task done

[Bug] cannot assign sort tags to some channel rewards #3031

dennisrijsdijk opened this issue Mar 1, 2025 · 0 comments
Labels
Bug A defect in the app

Comments

@dennisrijsdijk
Copy link
Collaborator

dennisrijsdijk commented Mar 1, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

During startup, channel rewards are fetched from Twitch. These channel rewards are not assigned the sortTags property, which breaks adding tags to that reward. Refreshing from the UI is not affected

Expected Behavior

Rewards added from external sources (eg. Twitch interface or extensions) that are loaded on startup should allow sort tags to be assigned to them

Steps To Reproduce

  1. Ensure you're logged into an affiliate or partner account
  2. Close Firebot
  3. Create a channel reward through Twitch's dashboard
  4. Start Firebot
  5. Create a channel reward sort tag
  6. Try to assign the sort tag to the newly created reward

Version

v5.64.0-dev

What operating system are you using Firebot on?

Linux Distro

Relevant log output

[2025-03-01 13:16:45.0343] - error: (Renderer) TypeError: Cannot read properties of undefined (reading 'some')
    at $ctrl.toggleSortTag (file:///code/projects/firebot/build/gui/app/directives/controls/sort-tags-row.js:96:41)
    at fn (eval at compile (/code/projects/firebot/node_modules/angular/angular.js:16548:15), <anonymous>:4:247)
    at callback (/code/projects/firebot/node_modules/angular/angular.js:29123:13)
    at ChildScope.$eval (/code/projects/firebot/node_modules/angular/angular.js:19523:28)
    at ChildScope.$apply (/code/projects/firebot/node_modules/angular/angular.js:19622:25)
    at HTMLInputElement.<anonymous> (/code/projects/firebot/node_modules/angular/angular.js:29127:19)
    at HTMLInputElement.dispatch (file:///code/projects/firebot/build/gui/js/plugins/jquery.min.js:3:10316)
    at q.handle (file:///code/projects/firebot/build/gui/js/plugins/jquery.min.js:3:8343)

Contact Details (Optional)

No response

@dennisrijsdijk dennisrijsdijk added the Bug A defect in the app label Mar 1, 2025
@github-project-automation github-project-automation bot moved this to Todo in Firebot Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app
Projects
Status: Todo
Development

No branches or pull requests

1 participant