Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dynamic Parameter Boolean-Typed Checkbox Tooltips Display <p></p> Tags #3004

Open
1 task done
phroggster opened this issue Feb 18, 2025 · 3 comments
Open
1 task done
Assignees
Labels
Bug A defect in the app Dev Approved The issue has been approved by a team member and can be worked on. Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release

Comments

@phroggster
Copy link
Collaborator

phroggster commented Feb 18, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Any dynamic parameters of a boolean type that contain a description property add a tooltip element that displays the provided description plus visible opening and closing paragraph tags. Radio inputs, and (most? all?) other dynamic parameters appear to not be affected, just the boolean checkbox types.

This does not appear to happen for non-dynamic parameter checkbox tooltips, such as the editSystemCommandModal "hidden" checkbox with a tooltip of "Hide this command from the !commands list", so is (likely) solely limited to dynamic parameters.

Screenshot of the !spamraidprotection Emote only mode tooltip:
Image

SEO: paragraph para <p> </p> tooltip less than greater than

Expected Behavior

No extra characters to appear in the tooltip.

Steps To Reproduce

  1. Open a system command that includes a boolean checkbox with a tooltip description, e.g. !spamraidprotection.
  2. Hover your cursor over a dynamic checkbox parameter's tooltip icon.

Version

v5.63+

What operating system are you using Firebot on?

Windows 10

@phroggster phroggster added the Bug A defect in the app label Feb 18, 2025
@github-project-automation github-project-automation bot moved this to Todo in Firebot Feb 18, 2025
@phroggster
Copy link
Collaborator Author

phroggster commented Feb 18, 2025

For the record: I did take a look at this the other week (apologies that I neglected to submit the issue at the time), and I'm not sure what is going wrong, or where these tags are actually coming from. Please don't assign this one to me.

@CaveMobster CaveMobster added the Dev Approved The issue has been approved by a team member and can be worked on. label Feb 18, 2025
@CaveMobster CaveMobster self-assigned this Feb 19, 2025
@CaveMobster CaveMobster added Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release labels Feb 19, 2025
@phroggster
Copy link
Collaborator Author

Fixed in e1374ba.

@CaveMobster
Copy link
Member

CaveMobster commented Feb 19, 2025

Fixed in e1374ba.

Oh thank you! Silly me forgot to put the issue reference in the commit. I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app Dev Approved The issue has been approved by a team member and can be worked on. Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release
Projects
Status: Todo
Development

No branches or pull requests

2 participants