Skip to content
This repository was archived by the owner on Apr 3, 2020. It is now read-only.

Commit 53b5c91

Browse files
committed
[Offline pages] Fixing restoring bookmarks filter, when offline pages disabled
Ensures that when enhanced bookmarks UI is restoring the past filter for content saved offline, and offline pages are disabled, it is treating the state as invalid and reverts to the all bookmarks state. BUG=581976 Review URL: https://codereview.chromium.org/1656103002 Cr-Commit-Position: refs/heads/master@{#372983} (cherry picked from commit d1b363e) Review URL: https://codereview.chromium.org/1662563002 . Cr-Commit-Position: refs/branch-heads/2623@{#241} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
1 parent aecedda commit 53b5c91

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUIState.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import android.text.TextUtils;
99

1010
import org.chromium.chrome.browser.UrlConstants;
11+
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
1112
import org.chromium.components.bookmarks.BookmarkId;
1213

1314
/**
@@ -151,8 +152,13 @@ boolean isValid(EnhancedBookmarksModel bookmarkModel) {
151152
&& !mFolder.equals(bookmarkModel.getRootFolderId());
152153
}
153154

154-
if (mState == STATE_FILTER && mFilter == null) return false;
155+
if (mState == STATE_FILTER) {
156+
if (mFilter == null) return false;
157+
if (mFilter == EnhancedBookmarkFilter.OFFLINE_PAGES) {
158+
return OfflinePageBridge.isEnabled();
159+
}
160+
}
155161

156162
return true;
157163
}
158-
}
164+
}

chrome/android/javatests/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,4 +241,12 @@ public void testOpenBookmarkManagerInOfflinePageNoPersist() throws InterruptedEx
241241
assertEquals(UrlConstants.BOOKMARKS_URL,
242242
EnhancedBookmarkUtils.getLastUsedUrl(getActivity()));
243243
}
244+
245+
@SmallTest
246+
@CommandLineFlags.Add(ChromeSwitches.DISABLE_OFFLINE_PAGES)
247+
public void testOpenBookmarkManagerInOfflinePageWhenDisabled() throws InterruptedException {
248+
openBookmarkManager("chrome-native://bookmarks/filter/OFFLINE_PAGES");
249+
EnhancedBookmarkDelegate delegate = mItemsContainer.getDelegateForTesting();
250+
assertEquals(EnhancedBookmarkUIState.STATE_ALL_BOOKMARKS, delegate.getCurrentState());
251+
}
244252
}

0 commit comments

Comments
 (0)