This repository was archived by the owner on Apr 3, 2020. It is now read-only.
Commit 2265a16
Add script to create Google Play Services's directory structure.
This script was originally in the Crosswalk repository, but keeping it
there means our Content Shell bots cannot access it and consequently
break with M43.
From the original Crosswalk commit (f4f6b75):
Ever since M42, building Chromium (and consequently Crosswalk) for
Android has required installing the Google Play Services library via
the `android` tool first. However, doing so involves manually
accepting an End User License Agreement (EULA), which makes things
very difficult to automate and also breaks our checkout and
configuration process for users who are building Crosswalk for the
first time.
Since that library is actually needed only by Chromium but not
Crosswalk, we have been working around this requirement. When
Crosswalk started tracking Chromium M42, we added a few changes to
chormium-crosswalk. One of them was making gyp not fail if some
directories created by the Google Play Services library were not
present.
This solution needs to be rethought for the upcoming M43, as there
is now a build system check in the android_tools repository to fail
if a certain file installed by that library is not found.
The script being added by this change is the answer to this, and is
being landed before M43 itself because it also works independently
of it. If the android_tools repository is checked out, it tries to
create the Google Play Services directories gyp looks for as well as
an empty file with the name that the android_tools build system
checks. This way, we get rid of the corresponding change in
chromium-crosswalk and prepare for the upcoming change in
android_tools.
BUG=XWALK-39551 parent 315fcf9 commit 2265a16
3 files changed
+92
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
797 | 797 | | |
798 | 798 | | |
799 | 799 | | |
800 | | - | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
801 | 813 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
723 | 723 | | |
724 | 724 | | |
725 | 725 | | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
726 | 738 | | |
727 | 739 | | |
728 | 740 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
0 commit comments