Deprecate all attribute related constraints and traits.

TiSiE · TiSiE · commit 99271aecdc9a · 2019-04-09T16:49:18.000+02:00
more information can be found here: https://thephp.cc/news/2019/02/help-my-tests-stopped-working#assertions-and-non-public-attributes
diff --git a/src/Constraint/DefaultAttributesValues.php b/src/Constraint/DefaultAttributesValues.php
@@ -15,6 +15,8 @@
  * Constraint to assert the existence and default values of attributes.
  *
  * @author Mathias Gelhausen <gelhausen@cross-solution.de>
+ * @deprecated Testing internal object state is bad practice.
+ *             (see: https://thephp.cc/news/2019/02/help-my-tests-stopped-working#assertions-and-non-public-attributes)
  */
 class DefaultAttributesValues extends \PHPUnit_Framework_Constraint
 {
diff --git a/src/TestCase/AssertDefaultAttributesValuesTrait.php b/src/TestCase/AssertDefaultAttributesValuesTrait.php
@@ -20,6 +20,9 @@
  * @method static void assertThat($value, \PHPUnit_Framework_Constraint $constraint, $message = '')
  *
  * @author Mathias Gelhausen <gelhausen@cross-solution.de>
+ *
+ * @deprecated Testing internal object state is bad practice.
+ *             (see: https://thephp.cc/news/2019/02/help-my-tests-stopped-working#assertions-and-non-public-attributes)
  */
 trait AssertDefaultAttributesValuesTrait
 {
diff --git a/src/TestCase/TestDefaultAttributesTrait.php b/src/TestCase/TestDefaultAttributesTrait.php
@@ -26,6 +26,8 @@
  * @property array $defaultAttributes
  *
  * @author Mathias Gelhausen <gelhausen@cross-solution.de>
+ * @deprecated Testing internal object state is bad practice.
+ *             (see: https://thephp.cc/news/2019/02/help-my-tests-stopped-working#assertions-and-non-public-attributes)
  */
 trait TestDefaultAttributesTrait
 {

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`	`* Constraint to assert the existence and default values of attributes.`
`16`	`16`	`*`
`17`	`17`	`* @author Mathias Gelhausen <[email protected]>`
	`18`	`+ * @deprecated Testing internal object state is bad practice.`
	`19`	`+ * (see: https://thephp.cc/news/2019/02/help-my-tests-stopped-working#assertions-and-non-public-attributes)`
`18`	`20`	`*/`
`19`	`21`	`class DefaultAttributesValues extends \PHPUnit_Framework_Constraint`
`20`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,9 @@`
`20`	`20`	`* @method static void assertThat($value, \PHPUnit_Framework_Constraint $constraint, $message = '')`
`21`	`21`	`*`
`22`	`22`	`* @author Mathias Gelhausen <[email protected]>`
	`23`	`+ *`
	`24`	`+ * @deprecated Testing internal object state is bad practice.`
	`25`	`+ * (see: https://thephp.cc/news/2019/02/help-my-tests-stopped-working#assertions-and-non-public-attributes)`
`23`	`26`	`*/`
`24`	`27`	`trait AssertDefaultAttributesValuesTrait`
`25`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,8 @@`
`26`	`26`	`* @property array $defaultAttributes`
`27`	`27`	`*`
`28`	`28`	`* @author Mathias Gelhausen <[email protected]>`
	`29`	`+ * @deprecated Testing internal object state is bad practice.`
	`30`	`+ * (see: https://thephp.cc/news/2019/02/help-my-tests-stopped-working#assertions-and-non-public-attributes)`
`29`	`31`	`*/`
`30`	`32`	`trait TestDefaultAttributesTrait`
`31`	`33`	`{`