Merge #964

964: Do not keep stdin open when running containers. r=Emilgardis a=Alexhuszagh



Co-authored-by: Alex Huszagh <[email protected]>

Author: bors[bot]

.changes/964.json

@@ -0,0 +1,4 @@
+{
+    "type": "fixed",
+    "description": "don't keep stdin open when running containers."
+}

src/docker/local.rs

@@ -101,11 +101,8 @@ pub(crate) fn run(
         ]);
     }
 
-    if io::Stdin::is_atty() {
-        docker.arg("-i");
-        if io::Stdout::is_atty() && io::Stderr::is_atty() {
-            docker.arg("-t");
-        }
+    if io::Stdin::is_atty() && io::Stdout::is_atty() && io::Stderr::is_atty() {
+        docker.arg("-t");
     }
     let mut image_name = options.image.name.clone();
     if options.needs_custom_image() {