Skip to content

Commit 557bac5

Browse files
Merge #981
981: Warn if both remote and docker-in-docker are set. r=Emilgardis a=Alexhuszagh Co-authored-by: Alex Huszagh <[email protected]>
2 parents 843ced9 + df7946f commit 557bac5

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/docker/remote.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -865,6 +865,10 @@ pub(crate) fn run(
865865

866866
let mount_prefix = MOUNT_PREFIX;
867867

868+
if options.in_docker() {
869+
msg_info.warn("remote and docker-in-docker are unlikely to work together when using cross. remote cross uses data volumes, so docker-in-docker should not be required.")?;
870+
}
871+
868872
// the logic is broken into the following steps
869873
// 1. get our unique identifiers and cleanup from a previous run.
870874
// 2. if not using persistent volumes, create a data volume

0 commit comments

Comments
 (0)