Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from SBEMU-X #45

Closed
Torinde opened this issue Dec 14, 2023 · 7 comments
Closed

Merge changes from SBEMU-X #45

Torinde opened this issue Dec 14, 2023 · 7 comments

Comments

@Torinde
Copy link
Contributor

Torinde commented Dec 14, 2023

There are some features added in SBEMU-X not yet merged into SBEMU. Also the README has some additional info.

I tried comparing both projects, but it seems some changes that were implemented in SBEMU are still highlighted by Github, so probably I'm not using properly the compare/merge function.

@crazii
Copy link
Owner

crazii commented Dec 14, 2023

@thp was creating PRs and I would merge them. I think he's still in progress. He probably doesn't have much free time to do them all at once.

@thp
Copy link
Collaborator

thp commented Dec 19, 2023

Once #51 and #52 are merged, there shouldn't be anything substantial left from SBEMU-X apart from code style, naming (SBEMU-X vs SBEMU) and SBEMU-X has the files for I/O trapping moved into a iotrap/ folder (not really necessary, of course).

@volkertb
Copy link
Collaborator

@thp Actually, isolating the I/O trapping code into a separate folder may be useful when we make another attempt to port SBEMU to the port-trapping API that @Baron-von-Riedesel implemented in the upstream version of HDPMI32i for the VSBHDA project. So good job!

@crazii
Copy link
Owner

crazii commented Dec 20, 2023

done.

@Torinde
Copy link
Contributor Author

Torinde commented Dec 20, 2023

Great. I opened here duplicates of the 3 issues at SBEMU-X that didn't have already a linked counterpart here.

Should I close this issue - or wait for the I/O trapping to be moved to a separate folder?

@crazii
Copy link
Owner

crazii commented Dec 20, 2023

@thp Actually, isolating the I/O trapping code into a separate folder may be useful when we make another attempt to port SBEMU to the port-trapping API that @Baron-von-Riedesel implemented in the upstream version of HDPMI32i for the VSBHDA project. So good job!

I don't think it helps much on that but put them in a separate folder is a good idea anyways.

@thp
Copy link
Collaborator

thp commented Dec 20, 2023

Archived the sbemu-x repo now. Thanks for merging the changes upstream :) I think this can be closed.

@Torinde Torinde closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants