Fixing non-relevant deps?

[epage]

The following test fails

#[cargo_test]
fn do_not_fix_non_relevant_deps() {
    let p = project()
        .no_manifest()
        .file(
            "foo/Cargo.toml",
            r#"
                [package]
                name = "foo"
                version = "0.1.0"
                edition = "2015"

                [dependencies]
                bar = { path = '../bar' }

                [workspace]
            "#,
        )
        .file("foo/src/lib.rs", "")
        .file("bar/Cargo.toml", &basic_manifest("bar", "0.1.0"))
        .file(
            "bar/src/lib.rs",
            r#"
                pub fn foo() -> u32 {
                    let mut x = 3;
                    x
                }
            "#,
        )
        .build();

    p.cargo("fix --allow-no-vcs")
        .env("__CARGO_FIX_YOLO", "1")
        .cwd("foo")
        .run();

    assert!(p.read_file("bar/src/lib.rs").contains("mut"));
}

Instead we have a ! in that assert!. Not seeing how cargo fix decides which packages to lock/fix

[epage]

Found it!

    // primary crates are compiled using a cargo subprocess to do extra work of applying fixes and
    // repeating build until there are no more changes to be applied
    opts.compile_opts.build_config.primary_unit_rustc = Some(wrapper);

    /// `is_primary` is true if this is a "primary package", which means it
    /// was selected by the user on the command-line (such as with a `-p`
    /// flag), see [`crate::core::compiler::BuildRunner::primary_packages`].

So yes, we're only supposed to fix selected packages.

[Pyr0de]

Does cargo fix not fix all the dependencies? Even with --workspace?

[epage]

From the tests and that code, it seems to fix "primary" package which means the packages the user selected.

User selections can include:

• Being in a directory of a package: only fix that
• Being in the directory of a virtual workspace: see --workspace
• -p foo: only fix that
• --workspace / --all: fix all workspace members
• --exclude foo: fix all workspace members except for those selected