From 00e02a10529a8b99edc8de4127af5243c275512f Mon Sep 17 00:00:00 2001 From: Kyle Machulis Date: Sat, 19 Oct 2019 13:38:20 -0700 Subject: [PATCH 1/3] Add param to turn off no-default-features builds on workspaces #66 Leaves --no-default-features step to build by default, but allows turning it off for workspaces. Fixes #66 --- azure/cargo-check.yml | 6 ++++-- azure/nightly-stages.yml | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/azure/cargo-check.yml b/azure/cargo-check.yml index f788f49..c4fcac8 100644 --- a/azure/cargo-check.yml +++ b/azure/cargo-check.yml @@ -2,6 +2,7 @@ parameters: rust: stable benches: false setup: [] + no_features: true all_features: false jobs: @@ -31,8 +32,9 @@ jobs: displayName: Check that Cargo.lock is satisfiable - script: cargo check --all --bins --examples --tests displayName: Check compilation w/ default features - - script: cargo check --all --bins --examples --tests --no-default-features - displayName: Check compilation w/ no features + - ${{ if eq('true', parameters.no_features) }}: + - script: cargo check --all --bins --examples --tests --no-default-features + displayName: Check compilation w/ no features - ${{ if eq('true', parameters.all_features) }}: - script: cargo check --all --bins --examples --tests --all-features displayName: Check compilation w/ all features diff --git a/azure/nightly-stages.yml b/azure/nightly-stages.yml index 35ca302..cd2aba4 100644 --- a/azure/nightly-stages.yml +++ b/azure/nightly-stages.yml @@ -6,6 +6,7 @@ parameters: test_ignored: false single_threaded: false check_all_features: true + check_no_features: true test_features: [] stages: @@ -25,6 +26,7 @@ stages: benches: ${{ parameters.benches }} setup: ${{ parameters.setup }} all_features: ${{ parameters.check_all_features }} + no_features: ${{ parameters.check_no_features }} rust: nightly - stage: ${{ format('{0}test', parameters.prefix) }} ${{ if ne(parameters.prefix, '') }}: From ceb795f68218c66c1b8fe2343a2b7ec58858fb71 Mon Sep 17 00:00:00 2001 From: Kyle Machulis Date: Sat, 19 Oct 2019 13:52:25 -0700 Subject: [PATCH 2/3] Readd Clippy now that toolchain install is fixed --- azure/nightly-stages.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/azure/nightly-stages.yml b/azure/nightly-stages.yml index cd2aba4..e60ef18 100644 --- a/azure/nightly-stages.yml +++ b/azure/nightly-stages.yml @@ -55,12 +55,11 @@ stages: parameters: name: rustfmt rust: nightly - # disabled until we get https://github.com/rust-lang/rustup.rs/issues/2005 - # - template: cargo-clippy.yml - # parameters: - # name: clippy - # setup: ${{ parameters.setup }} - # rust: nightly + - template: cargo-clippy.yml + parameters: + name: clippy + setup: ${{ parameters.setup }} + rust: nightly - ${{ if ne('', parameters.codecov_token) }}: - stage: ${{ format('{0}coverage', parameters.prefix) }} ${{ if ne(parameters.prefix, '') }}: From 35b9c6ab8b9b3f5e3d2b1fbeb78a5f0a92e40cb4 Mon Sep 17 00:00:00 2001 From: Kyle Machulis Date: Sat, 19 Oct 2019 15:50:41 -0700 Subject: [PATCH 3/3] Add cross parameter for nightly stages tests --- azure/nightly-stages.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/azure/nightly-stages.yml b/azure/nightly-stages.yml index e60ef18..fb76c57 100644 --- a/azure/nightly-stages.yml +++ b/azure/nightly-stages.yml @@ -5,6 +5,7 @@ parameters: setup: [] test_ignored: false single_threaded: false + cross: false check_all_features: true check_no_features: true test_features: [] @@ -41,6 +42,7 @@ stages: rust: nightly envs: ${{ parameters.envs }} setup: ${{ parameters.setup }} + cross: ${{ parameters.cross }} test_ignored: ${{ parameters.test_ignored }} single_threaded: ${{ parameters.single_threaded }} features: ${{ parameters.test_features }}