RabbitMQ package issue

[sgerbino]

• I've read Brief overview section and do understand basic concepts. [Yes]
• I've read F.A.Q. section and there is no solution to my problem there. [Yes]
• I've read Code of Conduct, I promise to be polite and will do my best at being constructive. [Yes]
• I've read Reporting bugs section carefully. [Yes]
• I've checked that all the hunter_add_package/find_package API used by me in the example is the same as in documentation. [Yes]
• I'm using latest Hunter URL/SHA1. [Yes]

While trying to use the package rabbitmq-c, CMake is unable to find and link the library. However, Hunter is able to download and build it properly. When testing the example within the Hunter repository I get the following output:

❯ cmake -DCMAKE_BUILD_TYPE=Debug ..
Including HunterGate: /Users/sgerbino/Projects/hunter/gate/cmake/HunterGate.cmake
-- The C compiler identification is AppleClang 12.0.0.12000032
-- The CXX compiler identification is AppleClang 12.0.0.12000032
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- [hunter] Calculating Toolchain-SHA1
-- [hunter] Calculating Config-SHA1
-- [hunter] HUNTER_ROOT: /Users/sgerbino/Projects/hunter
-- [hunter] [ Hunter-ID: xxxxxxx | Toolchain-ID: 1341f84 | Config-ID: 035647d ]
-- [hunter] RABBITMQ-C_ROOT: /Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install (ver.: 0.10.0)
CMake Error at CMakeLists.txt:14 (find_package):
  By not providing "Findrabbitmq-c.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "rabbitmq-c", but CMake did not find one.

  Could not find a package configuration file provided by "rabbitmq-c" with
  any of the following names:

    rabbitmq-cConfig.cmake
    rabbitmq-c-config.cmake

  Add the installation prefix of "rabbitmq-c" to CMAKE_PREFIX_PATH or set
  "rabbitmq-c_DIR" to a directory containing one of the above files.  If
  "rabbitmq-c" provides a separate development package or SDK, be sure it has
  been installed.


-- Configuring incomplete, errors occurred!
See also "/Users/sgerbino/Projects/hunter/examples/rabbitmq-c/build/CMakeFiles/CMakeOutput.log".
See also "/Users/sgerbino/Projects/hunter/examples/rabbitmq-c/build/CMakeFiles/CMakeError.log".

---

[rbsheth]

@sgerbino Can you check the config files in /Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install ? Let's see what the config name is.

Also, make sure you are following the example if you haven't already: https://hunter.readthedocs.io/en/latest/packages/pkg/rabbitmq-c.html

[sgerbino]

Thanks for the quick response.

I did follow the example you mentioned in my project and ran in to the same error I showed in the Hunter example.

I took a peak in to the directory you suggested, it seems I only have a pkgconfig in there.

❯ ls -R /Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install/
include		lib		licenses

/Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install//include:
amqp.h			amqp_framing.h		amqp_ssl_socket.h	amqp_tcp_socket.h

/Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install//lib:
librabbitmq.4.4.0.dylib		librabbitmq.a			librabbitmqd.4.4.0.dylib	librabbitmqd.a			pkgconfig
librabbitmq.4.dylib		librabbitmq.dylib		librabbitmqd.4.dylib		librabbitmqd.dylib

/Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install//lib/pkgconfig:
librabbitmq.pc

/Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install//licenses:
rabbitmq-c

/Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install//licenses/rabbitmq-c:
LICENSE-MIT

Here's what the contents look like:

❯ cat /Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install/lib/pkgconfig/librabbitmq.pc
prefix=/Users/sgerbino/Projects/hunter/_Base/xxxxxxx/1341f84/035647d/Install
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: rabbitmq-c
Description: An AMQP 0-9-1 client library
Version: 0.10.0
URL: https://github.com/alanxz/rabbitmq-c
Requires.private: openssl
Libs: -L${libdir} -lrabbitmq
Libs.private:
CFlags: -I${includedir}

[rbsheth]

Looks like the install step isn't working for some reason. As you can see here https://github.com/alanxz/rabbitmq-c/blob/master/CMakeLists.txt#L337 the config CMake file is supposed to be installed to ${CMAKE_INSTALL_LIBDIR}/cmake/rabbitmq-c. CMAKE_INSTALL_LIBDIR is defined since your pkgconfig install worked https://github.com/alanxz/rabbitmq-c/blob/master/CMakeLists.txt#L373.

The CMakeLists.txt install commands look okay to me. Can you get the version of rabbitmq-c you want to run and build it manually with a local install dir? That should give us more insight into why those files aren't being generated. What platform are you on?

[sgerbino]

I'm on macOS.

So it looks like the highest release version of rabbitmq-c is v0.10.0 and this version does not have the CMake files. This is also the default version that Hunter has.

When I make install their master branch, it properly generates the files you've pointed out.

Are we stuck waiting for a rabbitmq-c release for this to be fixed? Is there some workaround in the meantime to use master branch?

[rbsheth]

You can add a Hunter config file to test. https://github.com/cpp-pm/gate#usage-custom-config If it works, please send in a PR!

hunter_config(rabbitmq-c VERSION 0.10.0-773b883-t1
                    URL https://github.com/alanxz/rabbitmq-c/archive/773b883175ae50db024d59c7cce85c73e3f47e67.tar.gz
                    SHA1 eabbd8d179e49849a47c3c58e1900e6a8610d18d)

[sgerbino]

@rbsheth Thanks for the help. I've tested this locally with my project and it works. I've submitted a PR (#348) that does the following:

1. Adds the new version that works with CMake
2. Makes RabbitMQ cacheable (this was a requirement for my project)
3. Updates the example because the CMake ALIAS has changed from rabbitmq-c::rabbitmq-static to rabbitmq::rabbitmq-static

As a side note for anyone interested, my project uses -Werror and to get this compiling I added the following to my local config:

hunter_config(rabbitmq-c
   VERSION 0.10.0-773b883-t1
   CMAKE_ARGS
      CMAKE_C_FLAGS=-Wno-implicit-fallthrough
      CMAKE_CXX_FLAGS=-Wno-implicit-fallthrough
)