Local config.cmake file dir wrong

[xarthurx]

• I've read Brief overview section and do understand basic concepts. [Yes]
• I've read F.A.Q. section and haven't found an answer to my question. [Yes]
• I've read Code of Conduct, I promise to be polite and will do my best at being constructive. [Yes]

---

I tried to use a LOCAL config file for additional cmake arguments for the libigl package.
And it seems that hunter will try to find the config.cmake in a different location.
Instead of ${CMAKE_CURRENT_LIST_DIR}/cmake/Hunter/config.cmake, it will look for
${CMAKE_CURRENT_LIST_DIR}/_build/_deps/setuphunter-src/cmake/Hunter/config.cmake

cmake_minimum_required(VERSION 3.15)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake)

### Hunter snapshot that will be used ###
set(HUNTER_URL "https://github.com/cpp-pm/hunter/archive/v0.23.288.tar.gz")
set(HUNTER_SHA1 "6c9b2bc606d86ae31f96a62fc68f0a593024815b")
set(HUNTER_LOCAL_CONFIG ON)

# add packages
set(HUNTER_PACKAGES libigl Eigen spdlog nlohmann_json)

include(FetchContent)
FetchContent_Declare(SetupHunter GIT_REPOSITORY https://github.com/cpp-pm/gate)
FetchContent_MakeAvailable(SetupHunter)

project(sculptingUI)

message(STATUS "cmake begin for DigitalSculptingUI.")

add_subdirectory(src)

message(STATUS "cmake done for DigitalSculptingUI.")
message(STATUS "============================.")

The output:

[hunter ** FATAL ERROR **] Config not found: C:/Users/xarthur/source/sculpting_project/OPT_UI/_build/_deps/setuphunter-src/cmake/Hunter/config.cmake
[hunter ** FATAL ERROR **] [Directory:C:/Users/xarthur/source/sculpting_project/OPT_UI/_build/_deps/setuphunter-src]

------------------------------ ERROR -----------------------------
    https://hunter.readthedocs.io/en/latest/reference/errors/error.incorrect.input.data.html
------------------------------------------------------------------

CMake Error at C:/Libraries/hunter_pkg/_Base/Download/Hunter/0.23.288/6c9b2bc/Unpacked/cmake/modules/hunter_error_page.cmake:12 (message):
Call Stack (most recent call first):
  C:/Libraries/hunter_pkg/_Base/Download/Hunter/0.23.288/6c9b2bc/Unpacked/cmake/modules/hunter_fatal_error.cmake:20 (hunter_error_page)
  C:/Libraries/hunter_pkg/_Base/Download/Hunter/0.23.288/6c9b2bc/Unpacked/cmake/modules/hunter_user_error.cmake:7 (hunter_fatal_error)
  C:/Libraries/hunter_pkg/_Base/Download/Hunter/0.23.288/6c9b2bc/Unpacked/cmake/modules/hunter_set_config_location.cmake:50 (hunter_user_error)
  C:/Libraries/hunter_pkg/_Base/Download/Hunter/0.23.288/6c9b2bc/Unpacked/cmake/modules/hunter_apply_gate_settings.cmake:85 (hunter_set_config_location)
  C:/Libraries/hunter_pkg/_Base/Download/Hunter/0.23.288/6c9b2bc/Unpacked/cmake/modules/hunter_finalize.cmake:73 (hunter_apply_gate_settings)
  C:/Libraries/hunter_pkg/_Base/Download/Hunter/0.23.288/6c9b2bc/Unpacked/cmake/modules/hunter_add_package.cmake:23 (hunter_finalize)
  _build/_deps/setuphunter-src/CMakeLists.txt:142 (hunter_add_package)

[rbsheth]

That's odd - can you try HUNTER_FILEPATH_CONFIG for debugging? https://github.com/cpp-pm/gate/blob/master/CMakeLists.txt#L59

[xarthurx]

@rbsheth
The configuration seems fine, but generate in CMake shows the target that is supposed to link was not actually linked.

My config.cmake for Hunter is like this:

hunter_config(libigl
  VERSION ${HUNTER_libigl_VERSION}
  CMAKE_ARGS
  LIBIGL_WITH_EMBREE=ON
  LIBIGL_WITH_OPENGL=ON
  LIBIGL_WITH_OPENGL_GLFW=ON
  LIBIGL_WITH_OPENGL_GLFW_IMGUI=ON
  LIBIGL_USE_STATIC_LIBRARY=OFF
  )

These are configurations for the libigl lib.
When I don't use Hunter, these options will appear in the CMake GUI, not they are not. -- I'm not sure if it is supposed to be like this or not. But the target is indeed not linked, sth like:

CMake Error at src/MainUI/CMakeLists.txt:17 (add_executable):
  Target "mainUI" links to target "igl::opengl_glfw" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


CMake Error at src/MainUI/CMakeLists.txt:17 (add_executable):
  Target "mainUI" links to target "igl::opengl_glfw_imgui" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Error at src/MainUI/CMakeLists.txt:17 (add_executable):
  Target "mainUI" links to target "imgui::imgui" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?

[xarthurx]

Also, perhaps not related to this issue, though, that I tried another way of configure Hunter, not using the FetchContent way, but the manual approach:

cmake_minimum_required(VERSION 3.15)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake)


include("cmake/HunterGate.cmake")
HunterGate(
    URL "https://github.com/cpp-pm/hunter/archive/v0.23.288.tar.gz"
    SHA1 "6c9b2bc606d86ae31f96a62fc68f0a593024815b"
    FILEPATH "${CMAKE_MODULE_PATH}/Hunter/config.cmake"
)



project(sculptingUI)

hunter_add_package(eigen3)
hunter_add_package(libigl)
hunter_add_package(spdlog)
hunter_add_package(nlohmann_json)


message(STATUS "cmake begin for DigitalSculptingUI.")

add_subdirectory(src)

and got the same issue. It seems the local config.cmake file was not taken into account, or have I done sth wrong?

I'm a bit new for Hunter, but the manual from different places confused me a lot. May I ask what is the officially suggested way of doing Hunter?

[rbsheth]

You still need to call find_package after hunter_add_package - check out the example for libigl here: https://hunter.readthedocs.io/en/latest/packages/pkg/libigl.html

You need to do that for each package you add through Hunter.

[xarthurx]

@rbsheth

I have that in the src/CMakeList.txt file:

cmake_minimum_required(VERSION 3.15)

find_package(Eigen3 REQUIRED)
find_package(spdlog REQUIRED)
find_package(nlohmann_json REQUIRED)

# libigl
find_package(LIBIGL REQUIRED)

add_subdirectory(GeoLib)
add_subdirectory(MainUI)

and in MainUI\CMakeList.txt:

cmake_minimum_required(VERSION 3.15)
set(CMAKE_CXX_STANDARD 17)

project(mainUI)

# add project
FILE(GLOB SOURCES
  ${CMAKE_CURRENT_SOURCE_DIR}/*.h
  ${CMAKE_CURRENT_SOURCE_DIR}/*.cpp)

add_executable(${PROJECT_NAME} ${SOURCES})

# linking libs
target_link_libraries(${PROJECT_NAME} PRIVATE
	Eigen3::Eigen
	spdlog::spdlog # use fmt automatically
	nlohmann_json
	nlohmann_json::nlohmann_json
        igl::core
        igl::opengl_glfw
        igl::opengl_glfw_imgui
        igl::embree
        imgui::imgui
        GeoLib
  )

Only the set of igl options are not linked target. The rest is fine.

That's why I assume the CMAKE_ARGS are not taken correctly. (Only those are set by local config.cmake)
But I cannot find out where are the issues.

[xarthurx]

@rbsheth

FYI:
libigl/libigl#1695 (comment)

And sorry for diverging the initial question, which was not settled either.

[rbsheth]

Maybe the extra targets aren't set up correctly - I only used the base targets so I didn't try the others. It should work if it follows the correct CMake export strategy. Have you tried LIBIGL_EXPORT_TARGETS=ON?

[xarthurx]

@rbsheth I haven't.
But I tried with that and the issue is still there.

Perhaps this helps:
libigl/libigl#1375

[xarthurx]

FYI, when git clone and use libigl manually, it will download the 3d-party libs, like embree, glfw, etc.
The library will be used in the project as header-only.

I'm not an expert in the compilation systems, just post here what I can think of.

[KonStg]

Have same issue witrh this code:

cmake_minimum_required(VERSION 3.14)

set(GenerateWithoutError NO)
if(GenerateWithoutError)
    include("cmake/HunterGate.cmake") # contents: https://github.com/cpp-pm/gate/blob/b7529fb8cfd7c16d4adca789b011f8c5e8fb2a6f/cmake/HunterGate.cmake
    HunterGate(
        URL "https://github.com/cpp-pm/hunter/archive/v0.23.289.tar.gz"
        SHA1 "7d7323704780200a1575fc089d26f8a8a393a1fa"
        LOCAL
    )
else()
    set(HUNTER_LOCAL_CONFIG ON)
    set(HUNTER_PACKAGES fruits)
    include(FetchContent)
    FetchContent_Declare(SetupHunter GIT_REPOSITORY https://github.com/cpp-pm/gate)
    FetchContent_MakeAvailable(SetupHunter)
endif()

project(foo)

hunter_add_package(fruits)
find_package(fruits CONFIG REQUIRED)

add_executable(foo foo.cpp)
target_link_libraries(foo PUBLIC fruits::fruits_rosaceae)

But the problem disappears when set(GenerateWithoutError YES) is defined.

Using HUNTER_FILEPATH_CONFIG with relative path is not solving issue either.

UPDATE

If you specify an absolute path in HUNTER_FILEPATH_CONFIG, the problem occurs later, in case GIT_SUBMODULE is specified in the module config (for example hunter_config(imgui GIT_SUBMODULE Extensions/imgui-hunter)).

Again, this does not happen when using a direct call to HunterGate.

[rbsheth]

Yeah it is probably something related to the FetchContent mechanism - we'll have to debug that since it is newer and less tested than the "original" variant. Thank you for the reports!

[KonStg]

This issue could be investigated further with variable_watch(CMAKE_MODULE_PATH) command.

CMAKE_MODULE_PATH is a directory-scoped variable so after FetchContent_MakeAvailable(SetupHunter) (which internally calls add_subdirectory) the CMAKE_MODULE_PATH reverts to previous state (before FetchContent_MakeAvailable call) and it obviously without config.cmake directory.