forked from bitwarden/clients
-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Some parts of the code are using setTimeout
with arbitrary delay values that may not work as expected on different computers (as they are dependant on execution speed).
One example is the set of this.enableAnimations
on groupings.component.ts
setTimeout(() => {
// Enable panels animations only after a delay so that only user actions triger an animation.
// when component is initied, if a panel is displayed, we don't want the apparition of the panel
// to be animated.
this.enableAnimations = true;
}, 300);
This may be handled by this.activatePanel
that may trigger animation or not based on where it is called. It should trigger animation when called from everywhere except when called from this.route.queryParams.subscribe
(this assumption should be verified by looking the code more in details).
More details can be found there : #113 (comment)
Metadata
Metadata
Assignees
Labels
No labels