Delete pending from missing app

Author: sblaisot

registry/registry.go

@@ -464,7 +464,7 @@ func ApprovePendingVersion(c *space.Space, pending *Version, app *App) (*Version
 	return release, nil
 }
 
-func DeletePendingVersion(c *space.Space, version *Version, app *App) error {
+func DeletePendingVersion(c *space.Space, version *Version) error {
 	// Delete attachments (swift or couchdb)
 	err := version.RemoveAllAttachments(c)
 	if err != nil {

web/versions.go

@@ -197,10 +197,6 @@ func deletePendingVersion(c echo.Context) (err error) {
 	if appSlug == "" {
 		return errshttp.NewError(http.StatusNotFound, "App is missing in the URL")
 	}
-	app, err := registry.FindApp(nil, getSpace(c), appSlug, registry.Stable)
-	if err != nil {
-		return err
-	}
 
 	ver := stripVersion(c.Param("version"))
 	if ver == "" {
@@ -211,7 +207,7 @@ func deletePendingVersion(c echo.Context) (err error) {
 		return err
 	}
 
-	if err = registry.DeletePendingVersion(getSpace(c), version, app); err != nil {
+	if err = registry.DeletePendingVersion(getSpace(c), version); err != nil {
 		return err
 	}