Fix multiple deletion attemps on app removal

sblaisot · sblaisot · commit 53949005b0dc · 2023-04-20T14:26:17.000+02:00
diff --git a/registry/registry.go b/registry/registry.go
@@ -1156,7 +1156,9 @@ func RemoveAppFromSpace(s *space.Space, appSlug string) error {
 	}
 
 	// Then remove all live versions
-	app.Versions, err = FindAppVersionsCacheMiss(s, appSlug, Dev, Concatenated)
+	// NotConcatenated here to avoid trying to delete a stable version 3 times
+	// (one for stable, one for beta and one for dev channel)
+	app.Versions, err = FindAppVersionsCacheMiss(s, appSlug, Dev, NotConcatenated)
 	if err != nil {
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -1156,7 +1156,9 @@ func RemoveAppFromSpace(s *space.Space, appSlug string) error {`
`1156`	`1156`	`}`
`1157`	`1157`
`1158`	`1158`	`// Then remove all live versions`
`1159`		`- app.Versions, err = FindAppVersionsCacheMiss(s, appSlug, Dev, Concatenated)`
	`1159`	`+ // NotConcatenated here to avoid trying to delete a stable version 3 times`
	`1160`	`+ // (one for stable, one for beta and one for dev channel)`
	`1161`	`+ app.Versions, err = FindAppVersionsCacheMiss(s, appSlug, Dev, NotConcatenated)`
`1160`	`1162`	`if err != nil {`
`1161`	`1163`	`return err`
`1162`	`1164`	`}`