Skip to content

Conversation

@doubiz
Copy link

@doubiz doubiz commented Feb 8, 2016

Added 2 methods called get_bulk and `get_bulk!' that retrieve multiple documents given an array of ids.

@samlown
Copy link
Member

samlown commented Nov 26, 2016

@doubiz thanks for looking at this. Is there any specific advantage to your approach compared to just running WithDefaultValues.all.keys(['id1', 'id2', 'id3'])? I'm guessing the fact that you don't need a Design Document, but I'd just like to confirm this is your use case.

In addition, I'd like to ask for a slight reversal of the logic. I'd suggest that get_bulk is the main method, and get_bulk! raises the exception if get_bulk provides an empty response. I'd also suggest sticking with the default singular error message as opposed to a plural version to avoid confusion. Do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants