MB-30044: Make NetworkOrder classes use explicit single arg constructors

Make the single arg constructors of CollectionIDNetworkOrder and
ScopeIDNetworkOrder use explicit constructors.

Change-Id: I38c1199fd20ec9b5a9f1f1d69c1331b14cea8348
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/133882
Tested-by: Build Bot <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: rdemellow

include/memcached/dockey.h

@@ -171,7 +171,8 @@ using ScopeCollectionPair = std::pair<ScopeID, CollectionID>;
  */
 class CollectionIDNetworkOrder {
 public:
-    CollectionIDNetworkOrder(CollectionID v) : value(htonl(uint32_t(v))) {
+    explicit CollectionIDNetworkOrder(CollectionID v)
+        : value(htonl(uint32_t(v))) {
     }
 
     CollectionID to_host() const {
@@ -184,7 +185,7 @@ class CollectionIDNetworkOrder {
 
 class ScopeIDNetworkOrder {
 public:
-    ScopeIDNetworkOrder(ScopeID v) : value(htonl(uint32_t(v))) {
+    explicit ScopeIDNetworkOrder(ScopeID v) : value(htonl(uint32_t(v))) {
     }
 
     ScopeID to_host() const {
@@ -201,11 +202,11 @@ static_assert(sizeof(CollectionIDType) == 4,
 static_assert(sizeof(ScopeIDType) == 4, "ScopeIDType assumes 4-byte id");
 
 inline CollectionIDNetworkOrder CollectionID::to_network() const {
-    return {*this};
+    return CollectionIDNetworkOrder{*this};
 }
 
 inline ScopeIDNetworkOrder ScopeID::to_network() const {
-    return {*this};
+    return ScopeIDNetworkOrder{*this};
 }
 
 namespace std {